Skip to content

chore: bump sdrf-pipelines 0.1.4 -> 0.1.5 (fixes multi-residue mod site truncation) - #105

Merged
ypriverol merged 1 commit into
devfrom
chore/bump-sdrf-pipelines-0.1.5
Jun 9, 2026
Merged

ypriverol merged 1 commit into
devfrom
chore/bump-sdrf-pipelines-0.1.5

Conversation

@ypriverol

Copy link
Copy Markdown
Contributor

Summary

Bump sdrf-pipelines 0.1.4 → 0.1.5 in SDRF_PARSING (the step that produces diann_config.cfg via parse_sdrf convert-diann).

Why

0.1.4's parse_sdrf convert-diann emits multi-residue modification sites comma-separated, e.g. for an SDRF NT=Phospho;TA=S,T,Y:

--var-mod Phospho,79.966331,S,T,Y

DIA-NN keeps only the first residue of a comma-separated site list (the rest land in the 4th "label" field), so it logs Modification Phospho … at S will be considered as variable and silently drops pT and pY. This affects any modification on multiple residues (e.g. Oxidation,…,M,P → M only).

Confirmed on our PXD049692 phospho-diaPASEF reanalysis (DIA-NN 2.5.1): the run captured Serine phosphosites only.

0.1.5 fixes the converter to concatenate multi-residue sites and merge same-(name, mass) entries:

Phospho;TA=S,T,Y  → Phospho,79.966331,STY
Oxidation;TA=M,P  → Oxidation,15.994915,MP

Notes

  • Container tag verified published: biocontainers/sdrf-pipelines:0.1.5--pyhdfd78af_0 (bioconda latest_version: 0.1.5).
  • Two-line change; the fix itself lives in sdrf-pipelines (converters/diann/modifications.py, released in 0.1.5).
  • Datasets with multi-residue mods (phospho, etc.) should be re-run after this lands to capture all target residues.

0.1.4's parse_sdrf convert-diann emits multi-residue modification sites
comma-separated (e.g. Phospho,79.966331,S,T,Y), which DIA-NN truncates to the
first residue only (S) -- silently dropping pT/pY (confirmed on PXD049692) and
any modification on multiple residues. 0.1.5 fixes the converter to concatenate
sites (S,T,Y -> STY, M,P -> MP).

Container verified published: biocontainers/sdrf-pipelines:0.1.5--pyhdfd78af_0
(bioconda latest_version 0.1.5).
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 97985f3e-2235-4dde-995d-e80e45644606

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-sdrf-pipelines-0.1.5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026 •

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7828a87

+| ✅ 108 tests passed       |+
#| ❔  18 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml

❔ Tests ignored:

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-06-09 05:12:16

@ypriverol
ypriverol merged commit e7e6faa into dev Jun 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant