Repository navigation
chore: bump sdrf-pipelines 0.1.4 -> 0.1.5 (fixes multi-residue mod site truncation) - #105
Conversation
0.1.4's parse_sdrf convert-diann emits multi-residue modification sites comma-separated (e.g. Phospho,79.966331,S,T,Y), which DIA-NN truncates to the first residue only (S) -- silently dropping pT/pY (confirmed on PXD049692) and any modification on multiple residues. 0.1.5 fixes the converter to concatenate sites (S,T,Y -> STY, M,P -> MP). Container verified published: biocontainers/sdrf-pipelines:0.1.5--pyhdfd78af_0 (bioconda latest_version 0.1.5).
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Summary
Bump sdrf-pipelines
0.1.4→0.1.5inSDRF_PARSING(the step that producesdiann_config.cfgviaparse_sdrf convert-diann).Why
0.1.4'sparse_sdrf convert-diannemits multi-residue modification sites comma-separated, e.g. for an SDRFNT=Phospho;TA=S,T,Y:DIA-NN keeps only the first residue of a comma-separated site list (the rest land in the 4th "label" field), so it logs
Modification Phospho … at S will be considered as variableand silently drops pT and pY. This affects any modification on multiple residues (e.g.Oxidation,…,M,P→ M only).Confirmed on our PXD049692 phospho-diaPASEF reanalysis (DIA-NN 2.5.1): the run captured Serine phosphosites only.
0.1.5fixes the converter to concatenate multi-residue sites and merge same-(name, mass) entries:Notes
biocontainers/sdrf-pipelines:0.1.5--pyhdfd78af_0(biocondalatest_version: 0.1.5).converters/diann/modifications.py, released in 0.1.5).