Repository navigation
fix(diann): use toList() not collect() for per-run mass-acc triples (runtime crash on DIA-NN >= 2.5.0) - #106
Conversation
The DIA-NN >= 2.5.0 mass-accuracy branch maps each PRELIMINARY log to a [ms2,ms1,sw] triple, then aggregates. collect() FLATTENS nested lists, so the downstream .map received a flat list of Doubles and 'it[0]' threw 'Unknown method invocation getAt on Double type' at runtime. toList() collects the per-run triples without flattening. Caught by the Module 7 / DIA-NN 2.5.1 cluster validation (CI only exercises <2.5.0, which takes the other branch).
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Summary
Hotfix for a runtime crash in the DIA-NN >= 2.5.0 mass-accuracy branch added in #104.
ch_parsed_valsmaps each PRELIMINARY log to a[ms2, ms1, sw]triple, then.collect().map { rows -> rows.collect { it[0] } ... }. Nextflow's.collect()flattens nested lists, sorowswas a flat list of Doubles andit[0]threw:Fix:
.collect()->.toList()(collects the per-run triples without flattening).How it slipped through
CI only runs DIA-NN <= 2.2.0, which takes the
else(assemble-log) branch; the new >= 2.5.0 branch was first executed by the Module 7 / DIA-NN 2.5.1 cluster validation, which caught it after the 6 PRELIMINARY tasks. The preliminary masses themselves were captured correctly (MS1 ~2.5 ppm); only the aggregation crashed.