Repository navigation
Release 2.1.0 - Integration with wiff converter #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
34d7bbb
Initial plan
Copilot 415ecf4
fix: default local_input_type to raw and enforce supported formats
Copilot a532e72
fix: hoist local_input_type guard to workflow entry, bump to 2.1.0dev
claude e63a3ed
feat: accept Bruker .d archive variants as --local_input_type
claude 1b4a409
style: reformat parameters.md table with prettier
claude 970c3e6
fix(ebi): restore cleaner ASSEMBLE_EMPIRICAL_LIBRARY resource scaling
claude ac84491
Merge pull request #65 from bigbio/claude/fix-pr-bump-version-U3KFM
ypriverol 883919f
feat: add --mzml_convert to control TRFP conversion for Thermo .raw (…
claude 912c4c0
style: apply prettier to docs for --mzml_convert additions
claude b32e74d
fix: handle compound raw-file extensions in --local_input_type substi…
claude 5aabdda
fix: use stageInMode copy for native .raw to fix Thermo SDK symlink f…
Copilot a25b015
Merge pull request #68 from bigbio/claude/add-root-file-type-Xjb9L
ypriverol e7bdde8
Merge remote-tracking branch 'origin/dev' into copilot/fix-local-raw-…
ypriverol 57896bb
docs: add CHANGELOG entries for 2.1.0dev
ypriverol f9ae64a
Merge pull request #64 from bigbio/copilot/fix-local-raw-file-type
ypriverol 933c59b
update
yueqixuan 214e9b2
Merge pull request #72 from yueqixuan/claude/fix-raw-file-types-oopd6
ypriverol 9f7ce56
fix: mTRAQ
yueqixuan d71d60c
chore: phase 1 of nf-core 4.0.2 template sync — infrastructure only
ypriverol 48df483
chore: phase 2a — lint fixes and template badge/link consistency
ypriverol 6dc697e
fix(template-sync): repair CI lint regressions from phase 1
ypriverol 35fdfc5
ci: drop new nf-test.yml workflow from this PR
ypriverol 72270e9
fix: bump nf-schema 2.5.1 → 2.6.1 to silence config-validation warnings
ypriverol f961b51
ci: bump pinned Nextflow 25.04.0 → 25.10.4 to match manifest
ypriverol c3baba3
Merge pull request #77 from bigbio/template-sync-4.0.2
ypriverol f37543f
Merge branch 'bigbio:dev' into dev
yueqixuan f626705
support WIFF datasets
yueqixuan cc09e83
feat: restrict --input to .sdrf.tsv extension
ypriverol ab08ffd
feat(pridepy): integrate PRIDEPY_DOWNLOAD into workflow
Shen-YuFei a03ed54
fix(pridepy): address Copilot review comments
Shen-YuFei 80d6274
update
yueqixuan 4e0463c
update
yueqixuan 5c8c498
Merge pull request #78 from bigbio/restrict-input-sdrf-tsv
ypriverol 39ce5ee
bump quantms-utils and sdrf-pipelines image versions
yueqixuan 85385d6
docs: add minimal valid SDRF metadata examples
yueqixuan e0b7074
update
yueqixuan 1d1ba56
Merge branch 'dev' into dev
yueqixuan db6ba3a
update
yueqixuan 9aa13af
update
yueqixuan 8dc4c3e
Merge pull request #73 from yueqixuan/dev
ypriverol 0bdebf8
Merge pr-79 into fix branch and address review/CI issues
claude 99b1b13
fix(pridepy): wrap downloaded-files list as 1-tuple for combine()
claude f9452b0
Merge pull request #80 from bigbio/claude/fix-pr-79-conflicts-I8ae1
ypriverol e94e9ab
Merge pull request #81 from bigbio/main
ypriverol 352a61f
fix: address Copilot review feedback on workflows and docs
claude f9b449e
docs(changelog): mark 2.1.0 release as Sao Pablo
claude 74e0dfd
chore(config): default reindex_mzml to false
claude 1c4328d
Merge pull request #83 from bigbio/claude/fix-pr-82-QDwst
ypriverol 584bc05
Update version to 2.1.0 in nextflow.config
ypriverol 8d89bd0
Bump version from 1.0.0 to 2.1.0
ypriverol f864b7b
chore(profiles): add canonical test/test_full profile aliases
claude 3d9487a
fix(wiff_convert): point container to ghcr.io/bigbio mirrors
claude 73cdea5
fix: address GitHub issue for BlockedFlags
yueqixuan 175744b
docs(readme): point WiffConverter link to bigbio container mirror
claude d4d631e
fix: fetch pridepy version dynamically
yueqixuan d6d53f1
fix: modules.json
yueqixuan 6b80666
update
yueqixuan edfbb78
update
yueqixuan 76f0837
update
yueqixuan d26a7f0
Merge pull request #84 from yueqixuan/dev
ypriverol bbabe9c
feat(qpx): integrate QPX Parquet + MuData export into workflow
Shen-YuFei 41921cf
Merge branch 'bigbio:dev' into dev
Shen-YuFei edb57f2
chore(qpx): enable qpx export by default
Shen-YuFei 4790c17
docs: add 'Reproducing a DIA-NN GUI run' section to usage.md
claude 7bf4e1a
style: apply prettier formatting to docs/usage.md
claude 75b919f
Merge remote-tracking branch 'origin/dev' into claude/investigate-iss…
claude 685b4fd
Merge pull request #88 from bigbio/claude/investigate-issue-85-aiPKC
ypriverol a6edf66
fix(qpx): update container tag and fix CHANGELOG prettier formatting
Shen-YuFei 38e8375
fix(qpx): update container tag to 1.0.2--pyhdfd78af_1
Shen-YuFei 59227a8
fix(review): address copilot review comments on PR #87
Shen-YuFei 6d10fe0
fix(qpx): update modules.json git_sha to _1 container commit
Shen-YuFei 7cd38c8
style(ci): restore trailing comma per prettier
Shen-YuFei c878b66
Merge branch 'bigbio:dev' into dev
Shen-YuFei 2e60aad
Merge pull request #87 from Shen-YuFei/dev
ypriverol 3ede07d
chore(deps): upgrade sdrf-pipelines to 0.1.4
claude 520b231
docs(changelog): note QPX file format support in 2.1.0 Added
claude 1918a71
Merge pull request #89 from bigbio/claude/upgrade-sdrf-pipelines-rB7bC
ypriverol 9ff0015
fix(qpx,docs): address PR #82 review comments on QPX defaults and docs
claude b3ab56a
style(docs): apply prettier table padding to QPX parameters
claude e33fca5
fix(schema): drop QPX if/then clause, rely on runtime error
claude d92bac0
revert: undo local qpx container edit (tracked external module)
claude fabd963
Merge pull request #90 from bigbio/claude/review-pr-comments-06nre
ypriverol d3d18a7
feat(wiff): wire WIFF_CONVERT into schema, publishDir, and subworkflo…
Shen-YuFei 0d5ac7c
docs: document wiff/QPX/pridepy support and refresh AGENTS.md for 2.1.0
Shen-YuFei fbe7d22
chore: drop stale MS2RESCORE override, annotate QPX test profile, syn…
Shen-YuFei 102996a
docs: sync QPX export defaults after PR #90 and add parameters.md entry
Shen-YuFei 937426c
Merge pull request #91 from Shen-YuFei/dev
ypriverol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "$schema": "https://raw.githubusercontent.com/devcontainers/spec/main/schemas/devContainer.schema.json", | ||
| "name": "nfcore", | ||
| "image": "nfcore/devcontainer:latest", | ||
|
|
||
| "remoteUser": "root", | ||
| "privileged": true, | ||
|
|
||
| "remoteEnv": { | ||
| // Workspace path on the host for mounting with docker-outside-of-docker | ||
| "LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}" | ||
| }, | ||
|
|
||
| "onCreateCommand": "./.devcontainer/setup.sh", | ||
|
|
||
| "hostRequirements": { | ||
| "cpus": 4, | ||
| "memory": "16gb", | ||
| "storage": "32gb" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Customise the terminal command prompt | ||
| echo "export PROMPT_DIRTRIM=2" >> $HOME/.bashrc | ||
| echo "export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] '" >> $HOME/.bashrc | ||
| export PROMPT_DIRTRIM=2 | ||
| export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] ' | ||
|
|
||
| # Update Nextflow | ||
| nextflow self-update | ||
|
|
||
| # Update welcome message | ||
| echo "Welcome to the bigbio/quantmsdiann devcontainer!" > /usr/local/etc/vscode-dev-containers/first-run-notice.txt | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: bigbio/quantmsdiann
Length of output: 3400
🏁 Script executed:
Repository: bigbio/quantmsdiann
Length of output: 577
🏁 Script executed:
Repository: bigbio/quantmsdiann
Length of output: 6887
🌐 Web query:
Nextflow self-update command syntax and version parameter documentation💡 Result:
The Nextflow self-update command updates the Nextflow executable to the latest version. Basic syntax:
nextflow self-update[1][2][3]. This fetches the latest stable release by default [1][2]. For the latest edge (development) release, useNXF_EDGE=1 nextflow self-update[2][3]. To switch back from edge to stable, useNXF_EDGE=0 nextflow self-update[2]. Official documentation does not describe a direct command-line version parameter (e.g.,nextflow self-update 24.06.0) or flag like-versionfor self-update; only-hor-helpfor usage info [1][3]. Note that updates may fail if the executable lacks write permissions in its directory [2][4]. For version selection without updating the executable, use theNXF_VERenvironment variable, e.g.,NXF_VER=24.06.0-edge nextflow run ...[2].Citations:
Use pinned Nextflow version in devcontainer setup to match CI baseline (25.10.4).
Line 10 upgrades to latest at runtime, diverging from CI-tested version 25.10.4 and making local debugging inconsistent with pipeline CI.
However, the proposed fix syntax is incorrect—
nextflow self-updatedoes not accept a version parameter. According to Nextflow documentation, onlyNXF_EDGEcontrols self-update behavior (for stable vs edge releases), whileNXF_VERselects the version for running Nextflow, not updating it.Instead, pin the version by setting
NXF_VERbefore running Nextflow, or use the nf-core/setup-nextflow action (as CI does):Suggested alternatives
Option 1: Set NXF_VER environment variable
Option 2: Use nf-core/setup-nextflow action (mirrors CI approach)
Install via the GitHub action or equivalent approach used in CI workflows.
🤖 Prompt for AI Agents