Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
34d7bbb
Initial plan
Copilot Apr 21, 2026
415ecf4
fix: default local_input_type to raw and enforce supported formats
Copilot Apr 21, 2026
a532e72
fix: hoist local_input_type guard to workflow entry, bump to 2.1.0dev
claude Apr 21, 2026
e63a3ed
feat: accept Bruker .d archive variants as --local_input_type
claude Apr 21, 2026
1b4a409
style: reformat parameters.md table with prettier
claude Apr 21, 2026
970c3e6
fix(ebi): restore cleaner ASSEMBLE_EMPIRICAL_LIBRARY resource scaling
claude Apr 21, 2026
ac84491
Merge pull request #65 from bigbio/claude/fix-pr-bump-version-U3KFM
ypriverol Apr 22, 2026
883919f
feat: add --mzml_convert to control TRFP conversion for Thermo .raw (…
claude Apr 22, 2026
912c4c0
style: apply prettier to docs for --mzml_convert additions
claude Apr 22, 2026
b32e74d
fix: handle compound raw-file extensions in --local_input_type substi…
claude Apr 22, 2026
5aabdda
fix: use stageInMode copy for native .raw to fix Thermo SDK symlink f…
Copilot Apr 24, 2026
a25b015
Merge pull request #68 from bigbio/claude/add-root-file-type-Xjb9L
ypriverol Apr 24, 2026
e7bdde8
Merge remote-tracking branch 'origin/dev' into copilot/fix-local-raw-…
ypriverol Apr 24, 2026
57896bb
docs: add CHANGELOG entries for 2.1.0dev
ypriverol Apr 24, 2026
f9ae64a
Merge pull request #64 from bigbio/copilot/fix-local-raw-file-type
ypriverol Apr 24, 2026
933c59b
update
yueqixuan Apr 26, 2026
214e9b2
Merge pull request #72 from yueqixuan/claude/fix-raw-file-types-oopd6
ypriverol Apr 27, 2026
9f7ce56
fix: mTRAQ
yueqixuan Apr 29, 2026
d71d60c
chore: phase 1 of nf-core 4.0.2 template sync — infrastructure only
ypriverol May 1, 2026
48df483
chore: phase 2a — lint fixes and template badge/link consistency
ypriverol May 1, 2026
6dc697e
fix(template-sync): repair CI lint regressions from phase 1
ypriverol May 1, 2026
35fdfc5
ci: drop new nf-test.yml workflow from this PR
ypriverol May 1, 2026
72270e9
fix: bump nf-schema 2.5.1 → 2.6.1 to silence config-validation warnings
ypriverol May 1, 2026
f961b51
ci: bump pinned Nextflow 25.04.0 → 25.10.4 to match manifest
ypriverol May 1, 2026
c3baba3
Merge pull request #77 from bigbio/template-sync-4.0.2
ypriverol May 2, 2026
f37543f
Merge branch 'bigbio:dev' into dev
yueqixuan May 2, 2026
f626705
support WIFF datasets
yueqixuan May 2, 2026
cc09e83
feat: restrict --input to .sdrf.tsv extension
ypriverol May 3, 2026
ab08ffd
feat(pridepy): integrate PRIDEPY_DOWNLOAD into workflow
Shen-YuFei May 3, 2026
a03ed54
fix(pridepy): address Copilot review comments
Shen-YuFei May 3, 2026
80d6274
update
yueqixuan May 4, 2026
4e0463c
update
yueqixuan May 4, 2026
5c8c498
Merge pull request #78 from bigbio/restrict-input-sdrf-tsv
ypriverol May 4, 2026
39ce5ee
bump quantms-utils and sdrf-pipelines image versions
yueqixuan May 4, 2026
85385d6
docs: add minimal valid SDRF metadata examples
yueqixuan May 4, 2026
e0b7074
update
yueqixuan May 4, 2026
1d1ba56
Merge branch 'dev' into dev
yueqixuan May 4, 2026
db6ba3a
update
yueqixuan May 4, 2026
9aa13af
update
yueqixuan May 4, 2026
8dc4c3e
Merge pull request #73 from yueqixuan/dev
ypriverol May 4, 2026
0bdebf8
Merge pr-79 into fix branch and address review/CI issues
claude May 4, 2026
99b1b13
fix(pridepy): wrap downloaded-files list as 1-tuple for combine()
claude May 4, 2026
f9452b0
Merge pull request #80 from bigbio/claude/fix-pr-79-conflicts-I8ae1
ypriverol May 4, 2026
e94e9ab
Merge pull request #81 from bigbio/main
ypriverol May 5, 2026
352a61f
fix: address Copilot review feedback on workflows and docs
claude May 5, 2026
f9b449e
docs(changelog): mark 2.1.0 release as Sao Pablo
claude May 5, 2026
74e0dfd
chore(config): default reindex_mzml to false
claude May 5, 2026
1c4328d
Merge pull request #83 from bigbio/claude/fix-pr-82-QDwst
ypriverol May 5, 2026
584bc05
Update version to 2.1.0 in nextflow.config
ypriverol May 5, 2026
8d89bd0
Bump version from 1.0.0 to 2.1.0
ypriverol May 5, 2026
f864b7b
chore(profiles): add canonical test/test_full profile aliases
claude May 5, 2026
3d9487a
fix(wiff_convert): point container to ghcr.io/bigbio mirrors
claude May 5, 2026
73cdea5
fix: address GitHub issue for BlockedFlags
yueqixuan May 5, 2026
175744b
docs(readme): point WiffConverter link to bigbio container mirror
claude May 5, 2026
d4d631e
fix: fetch pridepy version dynamically
yueqixuan May 5, 2026
d6d53f1
fix: modules.json
yueqixuan May 5, 2026
6b80666
update
yueqixuan May 5, 2026
edfbb78
update
yueqixuan May 5, 2026
76f0837
update
yueqixuan May 5, 2026
d26a7f0
Merge pull request #84 from yueqixuan/dev
ypriverol May 5, 2026
bbabe9c
feat(qpx): integrate QPX Parquet + MuData export into workflow
Shen-YuFei May 6, 2026
41921cf
Merge branch 'bigbio:dev' into dev
Shen-YuFei May 6, 2026
edb57f2
chore(qpx): enable qpx export by default
Shen-YuFei May 6, 2026
4790c17
docs: add 'Reproducing a DIA-NN GUI run' section to usage.md
claude May 6, 2026
7bf4e1a
style: apply prettier formatting to docs/usage.md
claude May 6, 2026
75b919f
Merge remote-tracking branch 'origin/dev' into claude/investigate-iss…
claude May 6, 2026
685b4fd
Merge pull request #88 from bigbio/claude/investigate-issue-85-aiPKC
ypriverol May 6, 2026
a6edf66
fix(qpx): update container tag and fix CHANGELOG prettier formatting
Shen-YuFei May 7, 2026
38e8375
fix(qpx): update container tag to 1.0.2--pyhdfd78af_1
Shen-YuFei May 7, 2026
59227a8
fix(review): address copilot review comments on PR #87
Shen-YuFei May 7, 2026
6d10fe0
fix(qpx): update modules.json git_sha to _1 container commit
Shen-YuFei May 7, 2026
7cd38c8
style(ci): restore trailing comma per prettier
Shen-YuFei May 7, 2026
c878b66
Merge branch 'bigbio:dev' into dev
Shen-YuFei May 7, 2026
2e60aad
Merge pull request #87 from Shen-YuFei/dev
ypriverol May 7, 2026
3ede07d
chore(deps): upgrade sdrf-pipelines to 0.1.4
claude May 7, 2026
520b231
docs(changelog): note QPX file format support in 2.1.0 Added
claude May 7, 2026
1918a71
Merge pull request #89 from bigbio/claude/upgrade-sdrf-pipelines-rB7bC
ypriverol May 8, 2026
9ff0015
fix(qpx,docs): address PR #82 review comments on QPX defaults and docs
claude May 8, 2026
b3ab56a
style(docs): apply prettier table padding to QPX parameters
claude May 8, 2026
e33fca5
fix(schema): drop QPX if/then clause, rely on runtime error
claude May 8, 2026
d92bac0
revert: undo local qpx container edit (tracked external module)
claude May 8, 2026
fabd963
Merge pull request #90 from bigbio/claude/review-pr-comments-06nre
ypriverol May 8, 2026
d3d18a7
feat(wiff): wire WIFF_CONVERT into schema, publishDir, and subworkflo…
Shen-YuFei May 8, 2026
0d5ac7c
docs: document wiff/QPX/pridepy support and refresh AGENTS.md for 2.1.0
Shen-YuFei May 8, 2026
fbe7d22
chore: drop stale MS2RESCORE override, annotate QPX test profile, syn…
Shen-YuFei May 8, 2026
102996a
docs: sync QPX export defaults after PR #90 and add parameters.md entry
Shen-YuFei May 8, 2026
937426c
Merge pull request #91 from Shen-YuFei/dev
ypriverol May 8, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"$schema": "https://raw.githubusercontent.com/devcontainers/spec/main/schemas/devContainer.schema.json",
"name": "nfcore",
"image": "nfcore/devcontainer:latest",

"remoteUser": "root",
"privileged": true,

"remoteEnv": {
// Workspace path on the host for mounting with docker-outside-of-docker
"LOCAL_WORKSPACE_FOLDER": "${localWorkspaceFolder}"
},

"onCreateCommand": "./.devcontainer/setup.sh",

"hostRequirements": {
"cpus": 4,
"memory": "16gb",
"storage": "32gb"
}
}
13 changes: 13 additions & 0 deletions .devcontainer/setup.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#!/usr/bin/env bash

# Customise the terminal command prompt
echo "export PROMPT_DIRTRIM=2" >> $HOME/.bashrc
echo "export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] '" >> $HOME/.bashrc
export PROMPT_DIRTRIM=2
export PS1='\[\e[3;36m\]\w ->\[\e[0m\\] '

# Update Nextflow
nextflow self-update

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

echo "Searching for unpinned Nextflow self-update usage..."
rg -n --hidden '\bnextflow\s+self-update\b' .devcontainer .github/workflows

echo
echo "Searching for pinned Nextflow versions in CI..."
rg -n --hidden '25\.10\.4|setup-nextflow|NXF_VER' .github/workflows .devcontainer

Repository: bigbio/quantmsdiann

Length of output: 3400


🏁 Script executed:

#!/bin/bash
# Check the full context of the devcontainer setup.sh file
cat -n .devcontainer/setup.sh

Repository: bigbio/quantmsdiann

Length of output: 577


🏁 Script executed:

#!/bin/bash
# Search for how Nextflow is being invoked elsewhere in the repo
rg -n 'nextflow' .github/workflows --type yaml -B2 -A2 | head -100

Repository: bigbio/quantmsdiann

Length of output: 6887


🌐 Web query:

Nextflow self-update command syntax and version parameter documentation

💡 Result:

The Nextflow self-update command updates the Nextflow executable to the latest version. Basic syntax: nextflow self-update [1][2][3]. This fetches the latest stable release by default [1][2]. For the latest edge (development) release, use NXF_EDGE=1 nextflow self-update [2][3]. To switch back from edge to stable, use NXF_EDGE=0 nextflow self-update [2]. Official documentation does not describe a direct command-line version parameter (e.g., nextflow self-update 24.06.0) or flag like -version for self-update; only -h or -help for usage info [1][3]. Note that updates may fail if the executable lacks write permissions in its directory [2][4]. For version selection without updating the executable, use the NXF_VER environment variable, e.g., NXF_VER=24.06.0-edge nextflow run ... [2].

Citations:


Use pinned Nextflow version in devcontainer setup to match CI baseline (25.10.4).

Line 10 upgrades to latest at runtime, diverging from CI-tested version 25.10.4 and making local debugging inconsistent with pipeline CI.

However, the proposed fix syntax is incorrect—nextflow self-update does not accept a version parameter. According to Nextflow documentation, only NXF_EDGE controls self-update behavior (for stable vs edge releases), while NXF_VER selects the version for running Nextflow, not updating it.

Instead, pin the version by setting NXF_VER before running Nextflow, or use the nf-core/setup-nextflow action (as CI does):

Suggested alternatives

Option 1: Set NXF_VER environment variable

-# Update Nextflow
-nextflow self-update
+# Use pinned Nextflow version matching CI
+export NXF_VER="25.10.4"
 nextflow self-update

Option 2: Use nf-core/setup-nextflow action (mirrors CI approach)
Install via the GitHub action or equivalent approach used in CI workflows.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.devcontainer/setup.sh at line 10, The script currently runs nextflow
self-update which upgrades to latest; instead pin Nextflow to CI baseline
25.10.4 by setting the NXF_VER environment variable prior to invoking Nextflow
(do not attempt to pass a version to nextflow self-update); update the
.devcontainer/setup.sh workflow so it exports/exports-like NXF_VER=25.10.4 (or
uses the same nf-core/setup-nextflow approach as CI) and then runs nextflow
commands, and if you need edge behavior control use NXF_EDGE—remove or avoid
using nextflow self-update for version pinning.


# Update welcome message
echo "Welcome to the bigbio/quantmsdiann devcontainer!" > /usr/local/etc/vscode-dev-containers/first-run-notice.txt
125 changes: 0 additions & 125 deletions .github/CONTRIBUTING.md

This file was deleted.

4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ contact_links:
- name: Join nf-core
url: https://nf-co.re/join
about: Please join the nf-core community here
- name: "Slack #quantms channel"
url: https://nfcore.slack.com/channels/quantms
- name: "Slack #quantmsdiann channel"
url: https://nfcore.slack.com/channels/quantmsdiann
about: Discussion about the bigbio/quantmsdiann pipeline
5 changes: 2 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,14 @@ These are the most common things requested on pull requests (PRs).

Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release.

Learn more about contributing: [CONTRIBUTING.md](https://github.com/bigbio/quantmsdiann/tree/master/.github/CONTRIBUTING.md)
Learn more about contributing: [CONTRIBUTING.md](https://github.com/bigbio/quantmsdiann/tree/main/docs/CONTRIBUTING.md)
-->

## PR checklist

- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/bigbio/quantmsdiann/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the bigbio/quantmsdiann _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/bigbio/quantmsdiann/tree/main/docs/CONTRIBUTING.md)
- [ ] Make sure your code lints (`nf-core pipelines lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
- [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
Expand Down
12 changes: 7 additions & 5 deletions .github/actions/get-shards/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ inputs:
max_shards:
description: "Maximum number of shards allowed"
required: true
paths:
description: "Component paths to test"
required: false
tags:
description: "Tags to pass as argument for nf-test --tag parameter"
required: false
Expand All @@ -18,7 +21,7 @@ runs:
using: "composite"
steps:
- name: Install nf-test
uses: nf-core/setup-nf-test@v1
uses: nf-core/setup-nf-test@4069fbbaabe94c08faba4ad261bfa88225ba133f # v2
with:
version: ${{ env.NFT_VER }}
- name: Get number of shards
Expand All @@ -31,12 +34,11 @@ runs:
$(if [ -n "${{ inputs.tags }}" ]; then echo "--tag ${{ inputs.tags }}"; fi) \
--dry-run \
--ci \
--changed-since HEAD^) || nftest_exit_code=$?
if [ "${nftest_exit_code:-0}" -ne 0 ]; then
echo "nf-test command failed with exit code $nftest_exit_code"
--changed-since HEAD^) || {
echo "nf-test command failed with exit code $?"
echo "Full output: $nftest_output"
exit 1
fi
}
echo "nf-test dry-run output: $nftest_output"

# Default values for shard and total_shards
Expand Down
16 changes: 9 additions & 7 deletions .github/actions/nf-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,34 @@ inputs:
total_shards:
description: "Total number of test shards(NOT the total number of matrix jobs)"
required: true
paths:
description: "Test paths"
required: true
tags:
description: "Tags to pass as argument for nf-test --tag parameter"
required: false
runs:
using: "composite"
steps:
- name: Setup Nextflow
uses: nf-core/setup-nextflow@v2
uses: nf-core/setup-nextflow@b4ec1bc7c16a94435159de94a05253542fddf6ef # v3
with:
version: "${{ env.NXF_VERSION }}"

- name: Set up Python
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
with:
python-version: "3.12"
python-version: "3.14"

- name: Install nf-test
uses: nf-core/setup-nf-test@v1
uses: nf-core/setup-nf-test@4069fbbaabe94c08faba4ad261bfa88225ba133f # v2
with:
version: "${{ env.NFT_VER }}"
install-pdiff: true

- name: Setup apptainer
if: contains(inputs.profile, 'singularity')
uses: eWaterCycle/setup-apptainer@main
uses: eWaterCycle/setup-apptainer@3f706d898c9db585b1d741b4692e66755f3a1b40 # v2

- name: Set up Singularity
if: contains(inputs.profile, 'singularity')
Expand All @@ -45,7 +48,7 @@ runs:

- name: Conda setup
if: contains(inputs.profile, 'conda')
uses: conda-incubator/setup-miniconda@505e6394dae86d6a5c7fbb6e3fb8938e3e863830 # v3
uses: conda-incubator/setup-miniconda@8ee1f361103df19b6f8c8655fd3967a8ecb162d5 # v4
with:
auto-update-conda: true
conda-solver: libmamba
Expand All @@ -54,7 +57,6 @@ runs:
conda-remove-defaults: true

- name: Run nf-test
id: nf-test
shell: bash
env:
NFT_WORKDIR: ${{ env.NFT_WORKDIR }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
# NOTE - this doesn't currently work if the PR is coming from a fork, due to limitations in GitHub actions secrets
- name: Post PR comment
if: failure()
uses: mshick/add-pr-comment@b8f338c590a895d50bcbfa6c5859251edc8952fc # v2
uses: mshick/add-pr-comment@8e4927817251f1ff60c001f04568532b38e0b4a0 # v3
Comment thread
ypriverol marked this conversation as resolved.
Resolved
with:
message: |
## This PR is against the `${{github.event.pull_request.base.ref}}` branch :x:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
fail-fast: false
matrix:
NXF_VER:
- "25.04.0"
- "25.10.4"
test_profile: ["test_dia", "test_dia_dotd", "test_dda"]
exec_profile: ["docker"] # extended ci tests singularity.

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/clean-up.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
issues: write
pull-requests: write
steps:
- uses: actions/stale@5f858e3efba33a5ca4407a664cc011ad407f2008 # v10
- uses: actions/stale@b5d41d4e1d5dceea10e7104786b73624c18a190f # v10
with:
stale-issue-message: "This issue has been tagged as awaiting-changes or awaiting-feedback by an nf-core contributor. Remove stale label or add a comment otherwise this issue will be closed in 20 days."
stale-pr-message: "This PR has been tagged as awaiting-changes or awaiting-feedback by an nf-core contributor. Remove stale label or add a comment if it is still useful."
Expand Down
Loading
Loading