Skip to content

Add Sniffing support for interfaces and traits #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2022
Merged

Add Sniffing support for interfaces and traits #16

merged 1 commit into from
Apr 14, 2022

Conversation

jaymcp
Copy link
Member

@jaymcp jaymcp commented Apr 14, 2022 •
edited
Loading

Description

Implement support for sniffing interface and trait names in the same manner as classes/abstract classes

Changelog

  • Add Sniffing support for interfaces and traits

Types of changes:

  • New feature (non-breaking change which adds functionality).

Checklist:

  • All checks pass when running composer run all-checks.

@jaymcp jaymcp requested review from ampersarnie and jrmd April 14, 2022 13:15
jrmd
jrmd approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@jrmd jrmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaymcp jaymcp merged commit c18b0f4 into main Apr 14, 2022
@jaymcp jaymcp deleted the feature/traits-interfaces branch April 14, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmd jrmd jrmd approved these changes

@ampersarnie ampersarnie Awaiting requested review from ampersarnie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaymcp @jrmd