feat: add "registry" option for the deploy executor #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianjuar
reviewed
Feb 19, 2023
dianjuar
approved these changes
Feb 19, 2023
|
Interesting feature! I could use this feature and verdaccio in my integration test to make them more realistic. |
|
Feature available on ngx-deploy-npm/v/5.2.0 |
|
@dianjuar thanks for fixing the unit test and merging it! |
Totally makes sense, I was considering doing the same with the package I'm working on 🙁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Right now there's no ability to deploy to other registries. This might be useful if we want to add another deployment configuration for testing purposes
Issue Number: N/A
What is the new behavior?
Adding the new
--registryoptions for the deploy executor. This will allow to deploy the package into other registries or tools like https://verdaccio.org/docs/what-is-verdaccio/Does this PR introduce a breaking change?
Other information