Skip to content

Conversation

@kenkania
Copy link

@kenkania kenkania commented Sep 23, 2025

Make run_test.sh accept an overridable REPO_URL and always generate Maven settings.xml to support performance-focused Perf2 changes

  • Update run_test.sh to use REPO_URL=${REPO_URL:-artifactregistry://...} and always write a settings.xml that includes central (https://repo.maven.apache.org/maven2) and bilt-maven (artifactregistry://.../bilt-maven) for both repositories and pluginRepositories; build the custom wagon and write .mvn/extensions.xml only when REPO_URL is non-empty.
  • Add README_bilt.md documenting the Bilt AR Wagon fork usage, interface flags, performance notes, and future improvements.
  • Introduce tests/bilt-1-artifact/pom.xml defining org.acme:slow:1.0.0-SNAPSHOT with dependency on com.biltcard.common:egress-proxy:1.1.2 and Java 21 compiler plugin configuration.

📍Where to Start

Start in the run_test function within run_test.sh, then review the SETTINGS_XML generation and conditional wagon setup.


Macroscope summarized edf6282. (Automatic summaries will resume when PR exits draft mode or review begins).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue on line in run_test.sh:91:

Maven will always reference the artifactregistry:// URLs in settings.xml, but the Artifact Registry wagon is only configured when REPO_URL is set. If a user clears REPO_URL, Maven will fail to resolve those URLs without the wagon installed.

The root cause is that settings.xml is generated unconditionally with artifactregistry:// repositories, while the wagon (via extensions.xml) is only installed inside the if [[ -n "$REPO_URL" ]] block.

Consider only writing and using the custom settings.xml when REPO_URL is non-empty, so that Maven falls back to its default central repository behavior when no Artifact Registry URL is provided.

+    if [[ -n "$REPO_URL" ]]; then
-    echo "$SETTINGS_XML" > $run_dir/settings.xml
-    cmd="$cmd -s settings.xml"
+        echo "$SETTINGS_XML" > $run_dir/settings.xml
+        cmd="$cmd -s settings.xml"
+    fi

🚀 Reply to ask Macroscope to explain or update this suggestion.

👍 Helpful? React to give us feedback.

@kenkania kenkania changed the title Perf2 maven-central then bilt-maven Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants