Fix double exit bug in parallel pipelines#739
Conversation
Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu>
Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu>
|
OS = |
|
OS = |
|
OS:ubuntu-20.04 |
The reason why it worked on Ubuntu 20.04 was that the EXIT handler was not called, while on Ubuntu 24.04 it correctly is. Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu>
BolunThompson
force-pushed
the
double-exit-bug
branch
from
3a94bf6 to
07b09be
Compare
|
OS = |
|
OS:ubuntu-20.04 |
angelhof
left a comment
angelhof
left a comment
There was a problem hiding this comment.
Could you add read my comment and if you agree add a comment in the code so that we remember that? After this is done (or if my comment doesn't make sense) we will merge :)
Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu>
|
OS = |
|
OS:ubuntu-20.04 |
* Fix double-exit bug in parallel pipelines Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu> * Assert running_procs is positive Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu> * Fix: don't use exit handler The reason why it worked on Ubuntu 20.04 was that the EXIT handler was not called, while on Ubuntu 24.04 it correctly is. Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu> * Add comment explanation Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu> --------- Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu>
2 participants
Fixes #736, #738. This wasn’t a problem on Ubuntu 20.04 because the EXIT handler wasn’t called (for no obvious reason), so it only exited once.