Skip to content

Update sam2lca with missing dependency#62686

Merged
mencian merged 16 commits intobioconda:masterfrom
jfy133:sam2lca-missing-dependency
Apr 15, 2026
Merged

Update sam2lca with missing dependency#62686
mencian merged 16 commits intobioconda:masterfrom
jfy133:sam2lca-missing-dependency

Conversation

@jfy133
Copy link
Copy Markdown
Contributor

@jfy133 jfy133 commented Feb 16, 2026

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Comment thread recipes/sam2lca/meta.yaml Outdated
Comment thread recipes/sam2lca/meta.yaml Outdated
Comment thread recipes/sam2lca/meta.yaml Outdated
Comment thread recipes/sam2lca/meta.yaml Outdated
Comment thread recipes/sam2lca/meta.yaml Outdated
Comment thread recipes/sam2lca/meta.yaml Outdated
Copy link
Copy Markdown
Contributor

@thanhleviet thanhleviet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setuptools <81 addition makes sense for pkg_resources usage. However, the Linux build fails at the test phasepip check reports version mismatches:

xopen 2.0.2 requires isal>=1.6.1, but you have isal 0.0.0
xopen 2.0.2 requires zlib-ng>=0.4.1, but you have zlib-ng 0.0.0

This is a known conda/pip metadata mismatch — the conda packages for isal and zlib-ng report 0.0.0 to pip. The simplest fix is to drop pip check from the test commands, since the import and --help tests are sufficient:

test:
  imports:
    - sam2lca
  commands:
    - sam2lca --help

Alternatively, add pip to test: requires and keep pip check, but accept it may need ongoing maintenance as xopen evolves.

Comment thread recipes/sam2lca/meta.yaml Outdated
- pandas
- pysam
- python >=3.7
- python >=3.7,<=3.12
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question — is the Python upper bound needed? python <=3.12 means users on Python 3.13+ can't install this package. If the issue is purely pkg_resources (which the setuptools <81 pin already addresses), this upper bound may be unnecessary.

The upstream setup.py requires python >=3.6 with no upper bound. Consider whether setuptools <81 alone is sufficient, and if so, relax this to just python >=3.7.

If there's a known Python 3.12+ incompatibility in the code itself (beyond setuptools), then keeping it is fine — but it should be documented with a comment explaining why.

Comment thread recipes/sam2lca/meta.yaml Outdated
@@ -14,25 +14,27 @@ build:
- sam2lca = sam2lca.cli:cli
noarch: python
script: {{ PYTHON }} -m pip install . -vv
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-existing nit: This should include --no-deps --no-build-isolation per bioconda convention:

  script: {{ PYTHON }} -m pip install . --no-deps --no-build-isolation -vvv

Not blocking, but good to fix while you're here.

@mencian mencian enabled auto-merge (squash) April 15, 2026 21:39
@mencian mencian merged commit d2c5833 into bioconda:master Apr 15, 2026
6 checks passed
@jfy133
Copy link
Copy Markdown
Contributor Author

jfy133 commented Apr 16, 2026

Oops sorry completely forgot this, thanks @mencian !

@jfy133 jfy133 deleted the sam2lca-missing-dependency branch April 16, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants