Inconsistency between biome grit parsing and gritQL cli

[msquinn]

Hey y'all love the plugin support. I'm trying to use some of the jsx AST nodes that are in the standard lib for gritQL but I'm getting errors parsing the grit file, even when the same exact syntax from the grit CLI. For example, I want to match all jsx attributes that are 'style', so for the grit cli I would do this:

grit apply 'jsx_attribute($name, $value) where {
    $name <: `style`
}'

But if I take that same pattern, omitting the single quotes to my .grit file, I get an error parsing.

jsx_attribute($name, $value) where {
    $name <: `style`,
    register_diagnostic(span=$value, message="Avoid using inline style props. Consider using Tailwind classes instead for better maintainability and consistency.", severity="error")
}

Does biome not support jsx then? I assume it does, as this is all just the standard lib for grit. Lmk if I'm doing something wrong in my grit file as well.

[dyc3]

You need to use the PascalCase name, because it's matching against Biome's node names. https://biomejs.dev/reference/gritql/#matching-biome-syntax-nodes

Other than that, I can't quite figure out how to filter for just the style attributes like you want. I think its a bug. I'll go ahead and open an issue.

[dyc3]

#8079

[msquinn]

I think the actual issue is that I'm trying to use the args that get passed into the AST nodes. I think biome actually does support the tree-sitter snake_case names.

So this works:

jsx_attribute() as $match where {
  $match <: contains `style`,
  register_diagnostic(span=$match, message="Avoid using inline style props. Consider using Tailwind classes instead for better maintainability and consistency.", severity="warn")
}

Ideally though the params to the ast node functions would be supported, but I imagine there's some technical complexity around that.