🐛 Loading plugins from shared config

[milosworks]

Environment information

CLI:
  Version:                      2.0.0-beta.6
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  BIOME_THREADS:                unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           v23.11.0
  JS_RUNTIME_NAME:              node
  NODE_PACKAGE_MANAGER:         bun/1.2.10

Biome Configuration:
  Status:                       Loaded successfully
  Path:                         biome.jsonc
  Formatter enabled:            true
  Linter enabled:               true
  Assist enabled:               true
  VCS enabled:                  true

Workspace:
  Open Documents:               0

What happened?

Biome CANNOT resolve shared config packages from github neither load plugins from it when specifying the path

To reproduce:

1. Create a biome config and upload it to github, heres an example: https://github.com/milosworks/biomecf
2. In another project install biome and the biome config shared package: bun add -D github:milosworks/biomecf @biomejs/biome@beta
3. In the biome.json extend the shared config package

{
  "extends": "@milosworks/biomecf/biome"
}

4. Biome is not going to be able to load it, then specify it manually, example: ./node_modules/@milosworks/biomecf/biome.jsonc
5. This will try and load it, i believe this also doesnt work but if it does, it will NOT be able to load ANY plugins

My insights:

• Plugins
  Because the plugin path is relative, its probable biome is taking the root config (the one that extends) as root so its using that to try and get the plugin from that root path, not from the shared config path
• Extends
  I believe this is going to be a problem with biome not being able to resolve github packages, this is weird since in node_modules theres 0 difference to normal packages

Expected result

Biome should be able to extend and load plugins from the shared config package

Code of Conduct

• I agree to follow Biome's Code of Conduct

[arendjr]

Good news, I was able to confirm the resolver issue in beta.6, but it seems I cannot reproduce it with a build from main. I think it may have been fixed already, although I can't be sure what fix would be responsible :) Could you try a recent preview release and see if it works there for you?

I've renamed the issue so we can focus on the plugin issue.

[milosworks]

Good news, I was able to confirm the resolver issue in beta.6, but it seems I cannot reproduce it with a build from main. I think it may have been fixed already, although I can't be sure what fix would be responsible :) Could you try a recent preview release and see if it works there for you?

I've renamed the issue so we can focus on the plugin issue.

Thank you, I will test as soon as possible

[milosworks]

Good news, I was able to confirm the resolver issue in beta.6, but it seems I cannot reproduce it with a build from main. I think it may have been fixed already, although I can't be sure what fix would be responsible :) Could you try a recent preview release and see if it works there for you?

I've renamed the issue so we can focus on the plugin issue.

Sorry to bother you, where are the preview releases? Also, do you mean a build from next? As im using the beta build of v2

[dyc3]

They're in a feed in our discord. Here's the command for the latest one: npm i https://pkg.pr.new/biomejs/biome/@biomejs/biome@2807903

[milosworks]

Can confirm this issue has been solved on the latest preview release, including plugins not being loaded correctly!