Skip to content

refactor: add variables to format strings directly #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2024
Merged

refactor: add variables to format strings directly #3299

merged 2 commits into from
Jun 27, 2024

Conversation

@hamirmahal
Copy link
Contributor

@hamirmahal hamirmahal commented Jun 26, 2024

Summary

The goal of this change is to simplify the code base and improve readability where possible.

Test Plan

CI

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis labels Jun 26, 2024
hamirmahal
hamirmahal commented Jun 26, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request shouldn't cause any user-facing changes.

@hamirmahal hamirmahal changed the title style: simplify string formatting refactor: add variables to format strings directly Jun 27, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 27, 2024

CodSpeed Performance Report

Merging #3299 will not alter performance

Comparing hamirmahal:style/simplify-string-formatting (add4ec9) with main (3f311fe)

Summary

✅ 90 untouched benchmarks

ematipico
ematipico approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ematipico ematipico merged commit 5cc8a56 into biomejs:main Jun 27, 2024
@hamirmahal hamirmahal deleted the style/simplify-string-formatting branch June 27, 2024 05:16
@hamirmahal
Copy link
Contributor Author

hamirmahal commented Jun 27, 2024

You're welcome!

rishabh3112 pushed a commit to rishabh3112/biome that referenced this pull request Jul 6, 2024
@hamirmahal @rishabh3112
refactor: add variables to format strings directly (biomejs#3299)
2ff9703
This was referenced Aug 28, 2024
Open
Open
@Ramyromel Ramyromel mentioned this pull request Sep 9, 2024
Open
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
@Ramyromel Ramyromel mentioned this pull request Sep 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-Changelog Area: changelog A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: diagnostocis A-Formatter Area: formatter A-Linter Area: linter A-LSP Area: language server protocol A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hamirmahal @ematipico @Conaclos