perf(analyzer): reduce use of owned strings #5997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address #5990
I'm not sure this PR will fix ALL the performance bottlenecks of the batch mutations. Unfortunately, there is one point inside
batch.rswhere we're kinda forced to allocate a new strings because we need to print an entire node with its trivia, and that's also recursive. I will have to find a smart way to emit&strwhen printing a node. I will leave a comment to show the line.I also reduced the use of
to_strimmed_stringaround lint rules. What I find saddening is that we often try to print nodes instead of extracting the token we want to check. Maybe we should have some guide that explains how to do so.Test Plan
Current tests should still pass