-
-
Notifications
You must be signed in to change notification settings - Fork 781
feat: promote lint rules #7758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: promote lint rules #7758
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7526668
feat: promote lint rules
ematipico e8d858a
[autofix.ci] apply automated fixes
autofix-ci[bot] 5e7cb73
fix tests
ematipico 035d608
linting
ematipico 821e59c
merge with main
ematipico f8dc8cc
fix lint rules
ematipico 66be346
feedback
ematipico 20cd1e3
fix tests
ematipico cec9553
update snapshot
ematipico 4505ec1
chore: update severity
ematipico cdd38c0
Merge remote-tracking branch 'origin/next' into feat/promote-rules-230
ematipico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| "@biomejs/biome": minor | ||
| --- | ||
|
|
||
| Promoted new lint rules: | ||
| - Promoted `noNonNullAssertedOptionalChain` to the suspicious group | ||
| - Promoted `useReactFunctionComponents` to the `style` group | ||
| - Promoted `useImageSize` to the `correctness` group | ||
| - Promoted `useConsistentTypeDefinitions` to the `style` group | ||
| - Promoted `useQwikClasslist` to the `correctness` group | ||
| - Promoted `noSecrets` to the `security` group | ||
|
|
||
| Removed the lint rule `useAnchorHref`, because its use case is covered by `useValidAnchor`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 9 additions & 41 deletions
50
crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
crates/biome_cli/tests/snapshots/main_commands_format/html_disabled_by_default.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| --- | ||
| source: crates/biome_cli/tests/snap_test.rs | ||
| expression: redactor(content) | ||
| --- | ||
| ## `file.html` | ||
|
|
||
| ```html | ||
| <!DOCTYPE HTML> | ||
| ``` | ||
|
|
||
| # Termination Message | ||
|
|
||
| ```block | ||
| format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ | ||
|
|
||
| × No files were processed in the specified paths. | ||
|
|
||
| i Check your biome.json or biome.jsonc to ensure the paths are not ignored by the configuration. | ||
|
|
||
| i These paths were provided but ignored: | ||
|
|
||
| - file.html | ||
|
|
||
|
|
||
|
|
||
| ``` | ||
|
|
||
| # Emitted Messages | ||
|
|
||
| ```block | ||
| Formatted 0 files in <TIME>. No fixes applied. | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
869 changes: 424 additions & 445 deletions
869
crates/biome_configuration/src/analyzer/linter/rules.rs
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.