ci: fix clippy failure

[Conaclos]

Summary

Fix Clippy failure on CI.
I don't know why this doesn't fail locally. just lint/cargo lint pass the --all-features and --all-targets to Clippy. This should thus emit a diagnostic...

Test Plan

CI must pass

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1111918

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

Four AsyncRead/AsyncWrite implementations in the Windows service module have been refactored for cleaner control flow. The WouldBlock error handling now uses a no-op approach in the inner match arm instead of explicitly continuing the outer loop. This change maintains existing functionality whilst simplifying the control flow path across ClientReadHalf, ClientWriteHalf, ServerReadHalf, and ServerWriteHalf with no impact on error propagation or results.

Suggested labels

A-CLI

Suggested reviewers

• dyc3
• siketyan

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "ci: fix clippy failure" clearly references the purpose of the changeset and is directly related to the modifications made to crates/biome_cli/src/service/windows.rs. Whilst the title doesn't delve into the specific technical details (modifying WouldBlock error handling in AsyncRead/AsyncWrite implementations), it accurately and concisely describes why the changes were made. The title uses standard prefixing conventions and is specific enough to convey the nature of the change when scanning commit history.
Description Check	✅ Passed	The description directly relates to the changeset by explaining that it fixes a Clippy failure on CI. The author provides useful context about the discrepancy between local and CI environments, mentions the testing approach with just lint/cargo lint, and states the test plan. Whilst brief, the description clearly connects to the purpose of the code changes without being vague or off-topic.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch conaclos/fix-ci-fail

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecaed08 and 1111918.

📒 Files selected for processing (1)

• crates/biome_cli/src/service/windows.rs (4 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

crates/biome_*/**

📄 CodeRabbit inference engine (CLAUDE.md)

Place core crates under /crates/biome_*/

Files:

• crates/biome_cli/src/service/windows.rs

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Format Rust files before committing (e.g., via just f which formats Rust)
Document rules, assists, and options with inline rustdoc in source

Files:

• crates/biome_cli/src/service/windows.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: Test Node.js API
• GitHub Check: autofix
• GitHub Check: Documentation
• GitHub Check: Test (depot-ubuntu-24.04-arm-16)
• GitHub Check: Lint project (depot-windows-2022)
• GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
• GitHub Check: Test (depot-windows-2022-16)
• GitHub Check: Check Dependencies

🔇 Additional comments (4)

crates/biome_cli/src/service/windows.rs (4)

124-140: Clippy fix looks correct.

The empty block for WouldBlock naturally continues the loop, achieving the same behaviour as an explicit continue whilst satisfying Clippy's redundancy lint.

---

153-164: Consistent Clippy fix.

WouldBlock handling matches the pattern in ClientReadHalf. The empty block correctly allows the loop to continue polling for write readiness.

---

252-267: Server-side implementation aligned.

The WouldBlock handling follows the same pattern as the client implementations. Clippy fix is correct and maintains proper async I/O behaviour.

---

281-292: All implementations updated consistently.

The final WouldBlock handler completes the consistent pattern across all four async I/O implementations. The Clippy fix should resolve the CI failure whilst preserving correct named pipe behaviour.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}