Skip to content

Conversation

@Netail
Copy link
Member

@Netail Netail commented Nov 21, 2025

Summary

Extension of #8134

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: e0d9c7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Netail Netail changed the title chore: disable docstrings check chore: disable CodeRabbit docstrings check Nov 21, 2025
@Netail Netail changed the title chore: disable CodeRabbit docstrings check chore: disable docstrings in coderabbit Nov 21, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Walkthrough

A new pre_merge_checks.docstrings configuration has been added to .coderabbit.yaml with its mode set to off. This setting is positioned within the reviews section alongside existing finishing_touches settings. The change adjusts pre-merge validation behaviour by disabling docstring checks at the pre-merge stage, whilst leaving the finishing touches docstring configuration unaffected. No alterations to public entities were made.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: disabling docstring checks in the CodeRabbit configuration file.
Description check ✅ Passed The description references a related PR and indicates this is an extension of prior work, which is relevant to understanding the changeset's context.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d5dd20 and e0d9c7b.

📒 Files selected for processing (1)
  • .coderabbit.yaml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: arendjr
Repo: biomejs/biome PR: 7593
File: crates/biome_service/src/workspace/server.rs:1306-1306
Timestamp: 2025-09-25T12:32:59.003Z
Learning: In the biomejs/biome project, do not flag compilation errors during code review as they are handled by the existing test infrastructure and CI. Focus on other code quality aspects instead.
🔇 Additional comments (1)
.coderabbit.yaml (1)

37-39: LGTM—docstring features now fully disabled.

The pre-merge check configuration is properly structured and consistent with the existing finishing_touches.docstrings setting. Both docstring generation and pre-merge validation are now disabled across the board.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Netail Netail added this pull request to the merge queue Nov 21, 2025
Merged via the queue into biomejs:main with commit c085384 Nov 21, 2025
5 checks passed
@Netail Netail deleted the chore/disable-docstrings branch November 21, 2025 14:39
ryan-m-walker pushed a commit to ryan-m-walker/biome that referenced this pull request Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants