Skip to content

Conversation

@mdevils
Copy link
Contributor

@mdevils mdevils commented Dec 22, 2025

Summary

All biome commands were immediately failing in the benchmark. This PR fixes it.

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: c10ab27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Walkthrough

This pull request updates the benchmark configuration for Biome linting. The primary changes include: (1) updating the benchmark script to reference a specific biome.json configuration file instead of the parent directory, ensuring more precise configuration targeting, and (2) reorganising linting rules in the TypeScript benchmark configuration by adding complexity and correctness rules, removing deprecated ones, and relocating style-related rules (noVar and noWith) to the suspicious category. The adjustments maintain existing rule entries while reshuffling their categorical placement.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change—fixing failing biome commands in the benchmark by correcting the configuration path.
Description check ✅ Passed The description clearly states the problem (biome commands failing during benchmark) and confirms the PR fixes it, matching the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 619ac39 and c10ab27.

📒 Files selected for processing (2)
  • benchmark/bench.js
  • benchmark/ts-biome.json
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: arendjr
Repo: biomejs/biome PR: 7593
File: crates/biome_service/src/workspace/server.rs:1306-1306
Timestamp: 2025-09-25T12:32:59.003Z
Learning: In the biomejs/biome project, do not flag compilation errors during code review as they are handled by the existing test infrastructure and CI. Focus on other code quality aspects instead.
📚 Learning: 2025-08-05T14:43:29.581Z
Learnt from: dyc3
Repo: biomejs/biome PR: 7081
File: packages/@biomejs/biome/configuration_schema.json:7765-7781
Timestamp: 2025-08-05T14:43:29.581Z
Learning: The file `packages/biomejs/biome/configuration_schema.json` is auto-generated and should not be manually edited or reviewed for schema issues; any changes should be made at the code generation source.

Applied to files:

  • benchmark/bench.js
📚 Learning: 2025-11-24T18:06:12.048Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:12.048Z
Learning: Debug the WorkspaceWatcher by starting the daemon with cargo run --bin=biome -- start and running commands such as cargo run --bin=biome -- lint --use-server <path>

Applied to files:

  • benchmark/bench.js
📚 Learning: 2025-12-21T21:15:03.782Z
Learnt from: CR
Repo: biomejs/biome PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-12-21T21:15:03.782Z
Learning: Build debug binaries using `cargo build --bin biome` for development and triaging

Applied to files:

  • benchmark/bench.js
🔇 Additional comments (3)
benchmark/bench.js (2)

101-101: Fix looks correct.

The change from --config-path=../../ to --config-path=../../biome.json properly targets the specific configuration file, which should resolve the failing commands.


48-48: No action needed. The formatter's --config-path=../../ approach is valid — Biome's --config-path accepts both directory paths (which search for biome.json automatically) and file paths, so the inconsistency with the linter is intentional and harmless.

benchmark/ts-biome.json (1)

6-6: Verify rule organisation intent with PR author.

These are valid Biome rules in their correct categories (noAdjacentSpacesInRegex in complexity, useArrayLiterals in style, useValidTypeof/noVar in suspicious). Confirm whether updating the benchmark config with these rule reorganisations is intentional for this PR or should be separated.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mdevils mdevils merged commit 5deb141 into biomejs:main Dec 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants