Remove unused imports #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
reviewed
Mar 22, 2025
.gitignore
Outdated
| @@ -1 +1,2 @@ | |||
| __pycache__ | |||
| .idea/ | |||
There was a problem hiding this comment.
This needs to be in your local global .gitignore, not added here.
laanwj
reviewed
Mar 27, 2025
clang-format.py
Outdated
| for word in (['E.g:', argv[0]] + example_args): | ||
| print word, | ||
| print '' | ||
| print(word,) |
There was a problem hiding this comment.
This doesn't do anything in python 3. If the point is to print without a newline but a space after use
print(word, end=' ')
laanwj
reviewed
Mar 27, 2025
clang-format.py
Outdated
| print word, | ||
| print '' | ||
| print(word,) | ||
| print('') |
There was a problem hiding this comment.
print() works too to print a newline
|
Why are you changing the permissions of clang-format.py? |
|
Oof, I woulda wanted to remove that change, but I forgot to.
…On Fri, Mar 28, 2025 at 1:12 AM fanquake ***@***.***> wrote:
Why are you changing the permissions of clang-format.py?
—
Reply to this email directly, view it on GitHub
<#180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4W33JQVUW2XRL2SZRGL2WSHWXAVCNFSM6AAAAABZQ4JQDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJZHEZDIMRVGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: fanquake]*fanquake* left a comment
(bitcoin-core/bitcoin-maintainer-tools#180)
<#180 (comment)>
Why are you changing the permissions of clang-format.py?
—
Reply to this email directly, view it on GitHub
<#180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4W33JQVUW2XRL2SZRGL2WSHWXAVCNFSM6AAAAABZQ4JQDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJZHEZDIMRVGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
list-pulls.py: Remove unused import. termlib/attr.py: Explicit class methods. termlib/tableprinter.py: Adapts signature change. treehash512.py: Remove unused imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignore: Ignore PyCharm metadata.
clang-format.py: Python 3.
list-pulls.py: Remove unused import.
termlib/attr.py: Explicit class methods.
termlib/tableprinter.py: Adapts signature change.
treehash512.py: Remove unused imports.