Show permissions instead of whitelisted #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show detailed permissions instead of legacy "whitelisted" flag. These are formatted with `&` in between just like services flags. It reuses the "N/A" translation message if not. This removes the one-but-last use of `legacyWhitelisted`.
|
Concept ACK. |
|
Tested aCK |
maflcko
changed the title
jonatack
reviewed
Jul 16, 2020
promag
reviewed
Jul 16, 2020
| @@ -1120,7 +1120,15 @@ void RPCConsole::updateNodeDetail(const CNodeCombinedStats *stats) | |||
| ui->peerSubversion->setText(QString::fromStdString(stats->nodeStats.cleanSubVer)); | |||
| ui->peerDirection->setText(stats->nodeStats.fInbound ? tr("Inbound") : tr("Outbound")); | |||
| ui->peerHeight->setText(QString::number(stats->nodeStats.nStartingHeight)); | |||
| ui->peerWhitelisted->setText(stats->nodeStats.m_legacyWhitelisted ? tr("Yes") : tr("No")); | |||
There was a problem hiding this comment.
Why wasn't m_legacyWhitelisted removed?
There was a problem hiding this comment.
See OP
This removes the one-but-last use of legacyWhitelisted.
There was a problem hiding this comment.
Oh right, miss interpreted "one-but-last", sorry.
There was a problem hiding this comment.
done in bitcoin/bitcoin#20755 :)
| @@ -1120,7 +1120,15 @@ void RPCConsole::updateNodeDetail(const CNodeCombinedStats *stats) | |||
| ui->peerSubversion->setText(QString::fromStdString(stats->nodeStats.cleanSubVer)); | |||
| ui->peerDirection->setText(stats->nodeStats.fInbound ? tr("Inbound") : tr("Outbound")); | |||
| ui->peerHeight->setText(QString::number(stats->nodeStats.nStartingHeight)); | |||
| ui->peerWhitelisted->setText(stats->nodeStats.m_legacyWhitelisted ? tr("Yes") : tr("No")); | |||
| if (stats->nodeStats.m_permissionFlags == PF_NONE) { | |||
There was a problem hiding this comment.
nit, could #include <net_permissions.h>.
|
Post merge concept ACK, nice! |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 18, 2020
784ef8b gui: Show permissions instead of whitelisted (Wladimir J. van der Laan) Pull request description: Show detailed permissions instead of legacy "whitelisted" flag in the peer list details. These are formatted with `&` in between just like services flags. It reuses the "N/A" translation message if there are no special permissions. This removes the one-but-last use of `legacyWhitelisted`. Top commit has no ACKs. Tree-SHA512: 11982da4b9d408c74bc56bb3c540c0eb22506be6353aa4d4d6c64461d140f0587be194e2daad1612fddaa2618025a856b33928ad89041558f418f721f6abd407
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Dec 3, 2020
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Mar 19, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 1, 2021
Summary: Show detailed permissions instead of legacy "whitelisted" flag. These are formatted with `&` in between just like services flags. It reuses the "N/A" translation message if not. This is a backport of [[bitcoin-core/gui#34 | core-gui#34]] Test Plan: ` ninja && src/qt/bitcoin-qt` Menu Window > Peers. Select a peer to see its permissions. Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D10011
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show detailed permissions instead of legacy "whitelisted" flag in the peer list details.
These are formatted with
&in between just like services flags. It reuses the "N/A" translation message if there are no special permissions.This removes the one-but-last use of
legacyWhitelisted.