Switch MP_INCLUDE_DIR to global property
#168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanofsky
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Code review ACK b553830. Nice change that simplifies bitcoin/bitcoin#31741 and seems to make good use of cmake's global property feature. I suggested some tweaks below but they could be followups.
This change automates handling of `MP_INCLUDE_DIR` in the `target_capnp_sources` function, removing the need to manually propagate it across directories for both this project and downstream projects.
|
Thank you for your review! Your feedback has been addressed. |
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 31, 2025
Bump libmultiprocess library to include MP_INCLUDE_DIR definition from bitcoin-core/libmultiprocess#168 which can simplify the IPC cmake build as described bitcoin#31741 (comment) This update brings in the following changes: bitcoin-core/libmultiprocess#166 doc: rename from chaincodelabs to bitcoin-core bitcoin-core/libmultiprocess#168 Switch `MP_INCLUDE_DIR` to global property
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Apr 2, 2025
Bump libmultiprocess library to include MP_INCLUDE_DIR definition from bitcoin-core/libmultiprocess#168 which can simplify the IPC cmake build as described bitcoin#31741 (comment) This update brings in the following changes: bitcoin-core/libmultiprocess#166 doc: rename from chaincodelabs to bitcoin-core bitcoin-core/libmultiprocess#168 Switch `MP_INCLUDE_DIR` to global property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automates handling of
MP_INCLUDE_DIRin thetarget_capnp_sourcesfunction, removing the need to manually propagate it across directories for both this project and downstream projects.