Add add_data function for TxBuilder op_return #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logosstone
force-pushed
the
add_data_implement
branch
2 times, most recently
from
f9ce873 to
410eb82
Compare
logosstone
changed the title
|
I tested this and broadcast a transaction out with a message 🔥 🔥 🔥. The Kotlin type on the other side of this is |
thunderbiscuit
requested changes
Jun 22, 2022
There was a problem hiding this comment.
Very small nit, otherwise I think this is ready for merge.
Tested ACK 410eb82.
logosstone
force-pushed
the
add_data_implement
branch
from
410eb82 to
57ec72e
Compare
logosstone
force-pushed
the
add_data_implement
branch
from
57ec72e to
548217e
Compare
thunderbiscuit
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #132