Skip to content

Add Mnemonic type and key constructors from string #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

notmandatory
Copy link
Member

Description

Add the ability to create PublicDescriptorKey or SecretDescriptorKey from a string, including non-extended key types like WIF. An error is thrown if the string isn't a valid key.

Notes to the reviewers

The Mnemonic type also needs to be added back since only one constructor type can throw an error per the UDL limitations, and that means we need to type check the mnemonic words in the Mnemonic constructor.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory self-assigned this Oct 19, 2022
@notmandatory notmandatory added the enhancement New feature or request label Oct 19, 2022
@notmandatory notmandatory added this to the Release 0.11.0 milestone Oct 19, 2022
@thunderbiscuit thunderbiscuit self-requested a review October 25, 2022 17:49
@notmandatory
Copy link
Member Author

Closing this PR in favor of #219 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant