Skip to content

initial python docs for bdk #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

bitkarrot
Copy link

@bitkarrot bitkarrot commented Dec 10, 2024

Description

add Python docs

Checklists

All Submissions:

New Features:

  • I've added docs for the new feature

@notmandatory notmandatory added the documentation Improvements or additions to documentation label Dec 10, 2024
@bitkarrot
Copy link
Author

I need to go back and fix some syntax so this PR is not quite ready

 add script and instructions to readme

 fixup formatting

 fixup yaml workflow file

 modify generate docs script and format a bit better

add manually format api.rst for sections

 latest docs generated
@bitkarrot bitkarrot changed the title initial python docs attempt initial python docs for bdk Dec 10, 2024
output_file = 'docs/api.rst'

# Define categories and corresponding classes
categories = {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

categories are specified here. see index for all methods.

@bitkarrot
Copy link
Author

ok docs cleaned up with some instructions added. There are some warnings that still show; categories manually added in (#635 (comment)) to make menu nice.

python -m pip install --upgrade pip
pip install -r requirements.txt
pip install sphinx sphinx-rtd-theme

Copy link
Contributor

@andreasgriffin andreasgriffin Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed I have to install the pdkpython package, to get sphinx to be able to import the bdkpython module.

The steps from

- name: "Build wheel"
could be copied in here.

@andreasgriffin
Copy link
Contributor

Great PR. The docs looks very nice, and a rebase to master is without issues. Just the workflow needs to be tested (see #635 (comment) )
image

@thunderbiscuit thunderbiscuit mentioned this pull request Apr 30, 2025
3 tasks
@thunderbiscuit
Copy link
Member

This PR is being continued in #752.

@bitkarrot if you use your master branch for PRs, maintainers can't add fixes or rebase and force push. Feel free to continue the discussion in #752! And thanks for this, I know we've been slow at getting to it but it's awesome to see it work.

@thunderbiscuit
Copy link
Member

Thanks for all the hard work!

@github-project-automation github-project-automation bot moved this from In Progress to Done in BDK-Bindings Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants