Skip to content

Updated bdk-ffi to v0.10.0 (bdk 0.23) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

notmandatory
Copy link
Member

I also updated the README example to match current bdk-ffi API.

@notmandatory notmandatory self-assigned this Oct 21, 2022
@notmandatory notmandatory added the enhancement New feature or request label Oct 21, 2022
@notmandatory notmandatory added this to the Release 0.6.0 milestone Oct 21, 2022
@notmandatory
Copy link
Member Author

notmandatory commented Oct 27, 2022

@thunderbiscuit I know this isn't your specialty but I need an approval to merge this PR and then I'll make the next bdk-swift release. I don't want to get another YOLO badge. 🙄 🙏

@thunderbiscuit
Copy link
Member

thunderbiscuit commented Oct 28, 2022

No problem! I don't mind helping out on bdk-swift at all.

Where is the version number bump happening? I can't find a file with a version number 😆. Or is that happening in a different PR?

ACK 7ba5f37.

@notmandatory
Copy link
Member Author

Swift packaging doesn't actually put the version anywhere, it only uses the git tag version when adding a dependency. But for this PR I'm only updating the bdk-ffi and the related README fixes.

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@notmandatory notmandatory merged commit 7ba5f37 into bitcoindevkit:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants