Skip to content

Conversation

@ValuedMammal
Copy link
Collaborator

@ValuedMammal ValuedMammal commented Dec 4, 2025

Description

code_coverage.yml started failing as can be seen in a recent CI run. As a workaround I set the toolchain in the coverage workflow to nightly-2025-11-27 which is the version of the compiler in use the last time there was a successful coverage run.

The cause is unknown (to me) and likely doesn't originate from a crate in bdk. Assuming that a fix can be found, we can eventually revert this or otherwise keep the toolchain in code_coverage.yml up to date as needed.

Changelog notice

ci: Set code coverage toolchain to `nightly-2025-11-27`

Checklists

All Submissions:

@ValuedMammal ValuedMammal force-pushed the test_coverage_workflow branch 2 times, most recently from 44b29cd to fd3dfe8 Compare December 8, 2025 07:46
@ValuedMammal ValuedMammal marked this pull request as ready for review December 8, 2025 08:06
@ValuedMammal ValuedMammal changed the title ci: Test code coverage ci: Pin coverage toolchain to nightly-2025-11-27 Dec 8, 2025
@ValuedMammal ValuedMammal self-assigned this Dec 8, 2025
@ValuedMammal ValuedMammal added the github_actions Pull requests that update GitHub Actions code label Dec 8, 2025
@ValuedMammal ValuedMammal moved this to Needs Review in BDK Chain Dec 8, 2025
@ValuedMammal ValuedMammal added this to the Chain 0.24.0 milestone Dec 8, 2025
This fixes a CI failure resulting from use of rustc nightly
with `llvm-cov`.

refer to:
https://github.com/bitcoindevkit/bdk/actions/runs/19946035484.

As a workaround we change `code_coverage.yml` to set the toolchain
to `nightly-2025-11-27` which is a version of the compiler that
is known to work with `cargo-llvm-cov` at generating coverage
reports.
@ValuedMammal ValuedMammal force-pushed the test_coverage_workflow branch from fd3dfe8 to 0e8849c Compare December 8, 2025 17:57
Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0e8849c

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0e8849c.

I would maybe just open an issue to keep track of the use of nightly and remember to remove it once stuff upstream is fixed.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0e8849c

@notmandatory notmandatory merged commit be356d5 into bitcoindevkit:master Dec 10, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Chain Dec 10, 2025
@ValuedMammal ValuedMammal deleted the test_coverage_workflow branch December 11, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants