Add article about changes in coin selection module#114
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Nov 8, 2022
Merged
Conversation
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
csralvall
force-pushed
the
improving_coin_selection_blog_post
branch
2 times, most recently
from
1dfadb1 to
fe9c9f1
Compare
27 tasks
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
notmandatory
reviewed
Sep 1, 2022
Member
|
@csralvall I added some small language suggestions, but the content is great! Coin selection is a tricky topic and you explained it well. |
26 tasks
csralvall
force-pushed
the
improving_coin_selection_blog_post
branch
from
fe9c9f1 to
5523004
Compare
Contributor
Author
|
@notmandatory, thanks for the review, and sorry for the late reply! I've addressed all your corrections and have added some other minor fixes. |
Member
No problem @csralvall but I don't see any corrections here, double check that you pushed all your fixes to Github. Then I'm happy to merged this one. |
This blog post summarizes the work done during the Summer of Bitcoin initiative in the coin selection module of BDK and the ideas projected for its future.
csralvall
force-pushed
the
improving_coin_selection_blog_post
branch
from
5523004 to
f608e9e
Compare
Contributor
Author
|
@notmandatory, fixed! I forgot to add changes to the staging area. |
30 tasks
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This blog post summarizes the work done during the Summer of Bitcoin
initiative in the coin selection module of BDK and the ideas projected
for its future.