Merged
Conversation
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
danielabrozzoni
force-pushed
the
hwi_docs_update
branch
4 times, most recently
from
88c8ea0 to
d56fccc
Compare
24 tasks
logosstone
reviewed
Nov 8, 2022
danielabrozzoni
force-pushed
the
hwi_docs_update
branch
from
d56fccc to
616c097
Compare
Member
There was a problem hiding this comment.
I'm unfortunately unable to complete the tutorial at the moment (will try again tomorrow maybe on a different machine) but I wanted to leave at least the start of my comments. Really small nits.
Edit: syntax highlighting is not enabled for any code blocks at the moment, so those two comments at the end actually extend to all code blocks.
danielabrozzoni
force-pushed
the
hwi_docs_update
branch
from
616c097 to
ea7021b
Compare
Member
Author
|
Thanks for the review! Should be updated now :) |
danielabrozzoni
force-pushed
the
hwi_docs_update
branch
from
ea7021b to
f1c0027
Compare
Member
Author
|
Fixed, thanks! |
afilini
approved these changes
Nov 14, 2022
It was previously a tutorial, but, since it goes quite in deep into the rust-hwi internals, it's better suited as a blog post.
danielabrozzoni
force-pushed
the
hwi_docs_update
branch
from
f1c0027 to
d759896
Compare
Member
Author
|
Rebased |
afilini
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the old HWI tutorial in the blog section, as, being a post explaining all the rust-hwi internals, it's more suitable there. It also adds a new HWI tutorial, which should be more suitable for trying out HWI for the first time