-
Notifications
You must be signed in to change notification settings - Fork 70
Add get_merkle_block API call
#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_merkle_block API call
#28
Conversation
Pull Request Test Coverage Report for Build 3525791864Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Huh, I think the clippy error is unrelated to my change and the warning seems to only be added by the just-released 1.65.0 (see https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err). Not sure how to go about it? Should I fix it here, or do we want to do that in another PR? |
I think this is OK to fix in a different PR, for now you can allow the warning where needed with: #[allow(clippy::result_large_err)] |
We already have the `get_merkle_proof` call, but this one returns a `bitcoin::MerkleBlock`, which has additional data and is more often than not more useful than Electrum's counterpart.
1a73574 to
e40583a
Compare
Alright, I now set the attribute crate-wide and squashed again. |
notmandatory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK e40583a
vladimirfomene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK
…I call
e40583af13bd4ce812e91476ffa489553b4a26de Implement `get_merkle_block` API call (Elias Rohrer)
Pull request description:
We already have the `get_merkle_proof` call, but this one returns a `bitcoin::MerkleBlock`, which has additional data and is more often than not more useful than Electrum's counterpart.
ACKs for top commit:
notmandatory:
utACK e40583af13bd4ce812e91476ffa489553b4a26de
Tree-SHA512: a41eb0274c97903fcf358af31830fee0e90f3e31d1bd8bf9d43740f1feb56f7f253bfadec537c99479474599dab505a80551767637070da9d91d9eba03a05f7e
We already have the
get_merkle_proofcall, but this one returns abitcoin::MerkleBlock, which has additional data and is more often than not more useful than Electrum's counterpart.