Implement x axis manipulation in plotting tab#715
Merged
Conversation
gemenerik
added
enhancement
The last N seconds can now be plotted. A range can now be set in seconds (low, high limits). The range is automatically adapted to match the latest view in samples / seconds mode. This makes the range mode useful for zooming in on certain parts of the view. Changed x axis behavior such that the range configuration (samples, seconds, range) dictates x limits of the plot even if there is a (partial) lack of data for the range. Rather than stretching the plot as it fills up, now the entire plot limits are shown immediately. This immediate feedback helps with choosing a desirable x axis setting.
ToveRumar
approved these changes
Jun 17, 2024
Contributor
ToveRumar
left a comment
ToveRumar
left a comment
There was a problem hiding this comment.
Looks good! Nice feature!
Great commit message, makes it easy to review.
Image would help to see the change visually.
Member
Author
Thanks for the review! Adding an image to a GUI related pull request is a good idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last N seconds can now be plotted.
A range can now be set in seconds (low, high limits). The starting range is automatically adapted to match the latest view in samples / seconds mode. This makes the range mode useful for zooming in on certain parts of the plot.
Changed x axis behavior such that the range configuration (samples, seconds, range) dictates x limits of the plot even if there is a (partial) lack of data for the range. Rather than stretching the plot as it fills up, now the entire plot limits are shown immediately. This immediate feedback helps with choosing a desirable x axis setting.