Updated bootloader dialog to include images and forcing platform choice#762
Updated bootloader dialog to include images and forcing platform choice#762
Conversation
…e what platform they use
|
Great addition! |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the bootloader dialog to prevent users from accidentally flashing incorrect firmware by adding visual platform identification aids and enforcing explicit platform selection. The changes improve user guidance through the flashing process by making platform choice mandatory and providing contextual feedback.
Key changes:
- Added platform identification images to help users visually distinguish between device types
- Removed default platform selection (previously 'cf2'), requiring users to explicitly choose their platform
- Implemented tooltip feedback system to guide users on required actions before programming
Reviewed Changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/cfclient/ui/dialogs/bootloader.ui | Added image placeholders for 5 platform types and updated Qt enum syntax to use fully qualified names |
| src/cfclient/ui/dialogs/bootloader.py | Implemented image loading logic, removed default platform selection, and added program button state management with tooltips |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gemenerik
left a comment
gemenerik
left a comment
There was a problem hiding this comment.
Really nice addition.
I have some small notes on the images.
You talked about a warning before when you try to program without having selected a platform. I'm not seeing that here but maybe you decided against it? I think it is pretty clear as is anyways.
We have noticed that users sometimes accidentally flash the wrong firmware to their device. To help prevent this problem this PR has updated the bootloader dialog to include pictures that help the user notice the choice and choose the right platform as well as forcing the users to make a choice when they first open the dialog (no default choice).
Feedback in the form of tooltips have also been added to show the users what they might have missed doing in the dialog to be able to press the program button.