Check cfloader inputs before entering boot loader#783
Merged
stefanthorstenson merged 10 commits intomasterfrom Feb 25, 2026
Merged
Check cfloader inputs before entering boot loader#783stefanthorstenson merged 10 commits intomasterfrom
stefanthorstenson merged 10 commits intomasterfrom
Conversation
Contributor
Author
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the cfloader CLI to validate flash inputs earlier and improve the readability of the built-in help text, reducing the chance of entering bootloader operations with invalid parameters.
Changes:
- Reworks
--help/usage output into clearer “Actions” and “CRTP options” sections. - Validates
flashinputs before bootloader operations (file existence and target requirement for non-.zipimages). - Simplifies the flash execution path by removing redundant runtime checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ataffanel
requested changes
Feb 25, 2026
Member
ataffanel
left a comment
There was a problem hiding this comment.
Most copilot's comments make sense. I added one note about file read-ability.
Great improvement otherwise!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Inputs to cfloader tool have not been sanitized and error-checked, which for example can put the Crazyflie in bootloader mode even though the input commands and arguments are incorrect.
Fixes #779