-
-
Notifications
You must be signed in to change notification settings - Fork 96
Added timestamp to debug info #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Arnau Mora <[email protected]>
@devvv4ever would this be enough? Or what else is needed? Maybe add it to the zip file or something? |
It should be the the timestamp of date/time when the error occured. The time when the debug file is generated is not that important, but would be a nice addition also. Do we have some kind of possibility to log the time when the actual error occured? |
Signed-off-by: Arnau Mora <[email protected]>
Instead of the moment at which it was generated, the timestamp now matches the moment at which the error occurred (aka the error notification was shown). If manually generated, no timestamp is added since I think it really doesn't matter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine 👍
Would be cool to have it even if notifications are turned off, but with the current design we don't get the exception either, so I guess this is the best we can do for now. :)
btw: Would also be cool if you could update PR description with the new changes before requesting a review. It makes it easier to understand what this PR is about for the reviewer, since you don't have to read through the discussion and find all the information. It's valuable now and in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks, that's good for now and will make it easier for users to track the time of the error in most cases :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👍🏻 I added that the time is shown as local time and UTC, because I think server logs are often UTC and then it's easier to compare
Purpose
See #1312
Short description
Added a new line to the top of the debug info file to show the moment when the error occurred:
This is obtained using a new extra called
timestamp
, and passed toDebugInfoActivity
as the action of the notification shown by the error.Checklist