Drop LiveData #1414
Merged
Drop LiveData #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the usage of LiveData in favor of Kotlin Flow, simplifying reactive data updates and aligning with modern patterns. Key changes include:
- Removal of the compose-runtime-livedata dependency from the Gradle libs.versions.toml.
- Conversion of translations in AboutActivity from LiveData to a Flow and the corresponding change from observeAsState to collectAsStateWithLifecycle.
- Removal of LiveData-based queries in WebDavDocumentDao.
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Removed the compose-runtime-livedata dependency. |
| app/src/main/kotlin/at/bitfire/davdroid/ui/AboutActivity.kt | Replaced LiveData usage with Flow for translations and updated related imports accordingly. |
| app/src/main/kotlin/at/bitfire/davdroid/db/WebDavDocumentDao.kt | Eliminated a LiveData-based query method to align with the new reactive approach. |
Files not reviewed (3)
- .idea/codeStyles/Project.xml: Language not supported
- .idea/codeStyles/codeStyleConfig.xml: Language not supported
- app/build.gradle.kts: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced by Flow