Skip to content

Conversation

rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Jun 2, 2025

No description provided.

@rfc2822 rfc2822 self-assigned this Jun 2, 2025
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jun 2, 2025
@rfc2822 rfc2822 marked this pull request as ready for review June 2, 2025 09:48
@rfc2822 rfc2822 requested a review from Copilot June 2, 2025 09:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies a lint upgrade to convert URI parsing to use the .toUri() extension for improved consistency and readability.

  • Replaced multiple instances of Uri.parse() with string literals followed by .toUri()
  • Updated relevant import statements to use androidx.core.net.toUri across various UI, sync, and network modules

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/src/main/kotlin/at/bitfire/davdroid/ui/intro/BatteryOptimizationsPage.kt Replaces Uri.parse() with .toUri() for battery optimizations intent.
app/src/main/kotlin/at/bitfire/davdroid/ui/account/AccountScreen.kt Converts Uri.parse() to .toUri() and updates import accordingly.
app/src/main/kotlin/at/bitfire/davdroid/ui/TasksScreen.kt Uses .toUri() on market intent strings to improve consistency.
app/src/main/kotlin/at/bitfire/davdroid/ui/AppSettingsActivity.kt Adjusts battery optimizations setting URI conversion to .toUri().
app/src/main/kotlin/at/bitfire/davdroid/ui/AccountsScreen.kt Updates URI conversion to .toUri() for manage data saver intent.
app/src/main/kotlin/at/bitfire/davdroid/sync/TasksAppManager.kt Changes market URI parsing to use .toUri() for app detail intents.
app/src/main/kotlin/at/bitfire/davdroid/sync/SyncNotificationManager.kt Replaces URI.parse() with .toUri() for exception notification intent.
app/src/main/kotlin/at/bitfire/davdroid/network/GoogleLogin.kt Converts multiple Uri.parse() calls to .toUri() on configuration URIs.

@rfc2822 rfc2822 merged commit 0321e4a into main-ose Jun 2, 2025
8 checks passed
@rfc2822 rfc2822 deleted the uri-tostring branch June 2, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant