Increase SDK to 36 #1513
Merged
Increase SDK to 36 #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <[email protected]>
Signed-off-by: Arnau Mora <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Android SDK configuration to version 36 in preparation for Android 16 compatibility. Key changes include adding the enableOnBackInvokedCallback attribute in AndroidManifest.xml and updating compileSdk and targetSdk settings in build.gradle.kts.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/AndroidManifest.xml | Added a copyright notice and forcefully enabled on-back callback support. |
| app/build.gradle.kts | Updated compileSdk and targetSdk from 35 to 36 to align with Android 16. |
sunkup
requested changes
Jun 4, 2025
Signed-off-by: Arnau Mora <[email protected]>
sunkup
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
With Android 16 scheduled for June, I think we should start the migration to SDK 36.
I've followed the official docs:
Short description
I'd say there isn't much to migrate. The only thing I've done is to forcefully enable
enableOnBackInvokedCallbacksince it will be enabled by default on Android 16, and that would bring consistency.I've tested it out, and it works fine specially after #1495.
The only thing that bothers me a bit is this, but I guess it's nothing new.
Checklist