Fix ETag update logic in QueryChildDocumentsOperation #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the ETag handling logic within the QueryChildDocumentsOperation class. The issue was that the eTag field was incorrectly using the resource's eTag instead of the response's eTag value when listing WebDAV directories.
- Fixed ETag assignment to use the correct source value from the WebDAV response
app/src/main/kotlin/at/bitfire/davdroid/webdav/operation/QueryChildDocumentsOperation.kt
Show resolved
Hide resolved
|
@ArnyminerZ Please verify with app inspection of database (But I'll already merge because I'm quite sure) |
rfc2822
deleted the
1621-webdav-logic-for-updating-etag-appears-incorrect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the eTag was never set correctly when a WebDAV directory was listed.
This PR sets the eTag correctly.