Don't disable sync-ability of address books when set to manual only #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArnyminerZ Think you can reproduce this and see whether the PR fixes it? |
ArnyminerZ
approved these changes
Aug 19, 2025
rfc2822
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
👍🏻 Let's merge and release a new alpha/beta soon so that @devvv4ever can have a look on his Samsung phone.
rfc2822
force-pushed
the
1658-active-adress-book-is-disappearing-from-contacts-app-when-set-to-sync-manually-only-in-davx5
branch
from
6aa8ab7 to
81131f2
Compare
|
So this is ready to merge @sunkup, have fun when hitting the button :) |
sunkup
deleted the
1658-active-adress-book-is-disappearing-from-contacts-app-when-set-to-sync-manually-only-in-davx5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When sync interval is set to "only manually" for address books, we disable sync-ability completely (!) when we should only be disabling the sync on content changes.
Short description
It's obviously wrong to disable the sync entirely, but I could not reproduce the behaviour @devvv4ever described in the issue with my samsung phone (Android 10) and the samsung contacts app installed, so maybe you can check again with the PR version.
Checklist