Skip to content

Splitting up txs.ts into different stages based on purpose #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

hgrov52
Copy link

@hgrov52 hgrov52 commented Apr 3, 2018

Make sure all the right functions have been moved and that the code is properly refactored intuitively.

hnsgrvr and others added 30 commits February 27, 2018 16:50
@ghost ghost assigned hgrov52 Apr 3, 2018
@ghost ghost added the in progress label Apr 3, 2018
@colatkinson colatkinson self-requested a review April 3, 2018 20:26
Copy link
Member

@colatkinson colatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently does not pass Travis, and there are some syntax errors in txs.ts at a minimum. Also, can you guys merge in the latest master?

@ghost ghost assigned colatkinson Apr 3, 2018
@codecov
Copy link

codecov bot commented Apr 25, 2018

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 98.52%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files           6       10    +4     
  Lines         438      438           
  Branches       69       69           
=======================================
  Hits          433      433           
  Misses          5        5
Impacted Files Coverage Δ
lib/txs.ts 93.02% <ø> (-4.19%) ⬇️
lib/verify.ts 100% <ø> (ø) ⬆️
lib/tx-lock.ts 100% <100%> (ø)
lib/tx-commit.ts 100% <100%> (ø)
lib/tx-generate.ts 100% <100%> (ø)
lib/tx-unlock.ts 94.11% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a4caf...ab746ae. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants