Feature/134-complete-scope-crm-vol-3 #136
Conversation
|
Great work!
|
| */ | ||
| public function testAdd(): void | ||
| { | ||
| $activityTypeId = $this->activityTypeService->add( |
There was a problem hiding this comment.
For test add you must check
- is added type ok
- read added type
- compare some key fields
|
|
||
| $res = $this->activityTypeService->list(); | ||
|
|
||
| // Что за getActivities ? |
There was a problem hiding this comment.
Please, use English in comments
| } |
There was a problem hiding this comment.
@ZoolanderX add to CHANGELOG.md line - fix typehint errors in src/Services/CRM/Activity/Result/ActivityItemResult.php
| */ | ||
| class ActivityTypeResult extends AbstractCrmItem | ||
| { | ||
| public function getData(): array |
There was a problem hiding this comment.
I think this method is redundant, you can get all raw data with
getIterator()->getArrayCopy() on resultItem
| * @property-read string $TYPE | ||
| * @property-read string $VALUE | ||
| */ | ||
| class CommunicationResult extends AbstractCrmItem |
There was a problem hiding this comment.
if this *item you must add Item prefix to class name.
please add new issue «find and add tool to check naming conversation», responsible - mesilov
There was a problem hiding this comment.
| @@ -17,11 +17,8 @@ | |||
|
|
|||
| class OpenLineActivityItemResult extends ActivityItemResult | |||
| { | |||
| /** | |||
| * @return \Bitrix24\SDK\Services\CRM\Activity\Result\OpenLine\OpenLineProviderParams | |||
| */ | |||
| public function getProviderParams(): OpenLineProviderParams | |||
| { | |||
| return new OpenLineProviderParams($this->PROVIDER_PARAMS['USER_CODE']); | |||
There was a problem hiding this comment.
please check typehints and fix phpstan error
| @@ -17,9 +17,6 @@ | |||
|
|
|||
| class WebFormActivityItemResult extends ActivityItemResult | |||
| { | |||
There was a problem hiding this comment.
please check typehints and fix phpstan error
| /** | ||
| * This file is part of the bitrix24-php-sdk package. | ||
| * | ||
| * © Maksim Mesilov <[email protected]> |
| /** | ||
| * This file is part of the bitrix24-php-sdk package. | ||
| * | ||
| * © Maksim Mesilov <[email protected]> |
| * @throws \Bitrix24\SDK\Core\Exceptions\BaseException | ||
| */ | ||
| #[\PHPUnit\Framework\Attributes\TestDox('Batch add deals')] |
| * @throws BaseException | ||
| * @throws TransportException | ||
| */ | ||
| #[\PHPUnit\Framework\Attributes\TestDox('Batch list deals')] |
| /** | ||
| * This file is part of the bitrix24-php-sdk package. | ||
| * | ||
| * © Maksim Mesilov <[email protected]> |
There was a problem hiding this comment.
fix author to own contacts
Services\AI\Engine\Service\Typewith support methods:crm.activity.type.add- method registers a custom activity type with a name and iconcrm.activity.type.delete- delete a custom activity typecrm.activity.type.list- get a list of custom task typesServices\AI\Engine\Service\Communicationwith support methods:crm.activity.communication.fields- get a description of the communication