Skip to content

ElasticSearch related code refactory#2576

Merged
abitmore merged 17 commits into
developfrom
es-refactory
Jan 18, 2022
Merged

ElasticSearch related code refactory#2576
abitmore merged 17 commits into
developfrom
es-refactory

Conversation

@abitmore

@abitmore abitmore commented Jan 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Refactored code mainly in the sense of object-oriented programming.

BTW here is an interesting error during development. -_-!

.../elasticsearch.hpp:47:7: error: expected identifier before ‘(’ token
   47 |       DELETE  = 4,
      |       ^~~~~~

In Win32, DELETE is a macro used for dealing with ACLs (access control lists). (link)

@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Jan 10, 2022
@abitmore abitmore marked this pull request as ready for review January 16, 2022 23:20
@sonarqubecloud

sonarqubecloud Bot commented Jan 18, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

75.4% 75.4% Coverage
0.0% 0.0% Duplication

@abitmore abitmore merged commit c09bb5c into develop Jan 18, 2022
@abitmore abitmore deleted the es-refactory branch January 18, 2022 14:52
@abitmore abitmore mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.1.0 - Feature Release

Development

Successfully merging this pull request may close these issues.

1 participant

@abitmore