Skip to content

Extend get_order_book API to return more info#2638

Merged
abitmore merged 2 commits into
developfrom
pr-2637-orderbook-api
Sep 12, 2022
Merged

Extend get_order_book API to return more info#2638
abitmore merged 2 commits into
developfrom
pr-2637-orderbook-api

Conversation

@abitmore

Copy link
Copy Markdown
Member

PR for #2637 and blocksights/blocksights-open-explorer#9.

This PR adds 4 data fields into the order struct:

  • id - ID of the limit order
  • owner_id - owner account ID of the limit order
  • owner_name - owner account name of the limit order
  • expiration - expiration time of the limit order

The full order struct becomes:

   struct order
   {
      string                     price;
      string                     quote;
      string                     base;
      limit_order_id_type        id;
      account_id_type            owner_id;
      string                     owner_name;
      time_point_sec             expiration;
   };

The order_book struct itself is unchanged.

   struct order_book
   {
     string                      base;
     string                      quote;
     vector< order >             bids;
     vector< order >             asks;
   };

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.2% 81.2% Coverage
0.0% 0.0% Duplication

@abitmore
abitmore merged commit b5eeae8 into develop Sep 12, 2022
@abitmore
abitmore deleted the pr-2637-orderbook-api branch September 12, 2022 22:26
@abitmore abitmore linked an issue Sep 12, 2022 that may be closed by this pull request
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend get_order_book API to return order owner info

1 participant