[PM-16227] Move import to sdk and enable it in browser/web #12479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12479 +/- ##
==========================================
- Coverage 36.01% 35.94% -0.08%
==========================================
Files 3174 3175 +1
Lines 93357 93121 -236
Branches 16960 16969 +9
==========================================
- Hits 33623 33472 -151
+ Misses 57144 57052 -92
- Partials 2590 2597 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
quexten
changed the title
quexten
requested review from
addisonbeck,
gbubemismith and
Patrick-Pimentel-Bitwarden
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…rden/clients into km/pm-16227/ssh-import-web-browser
audreyality
reviewed
Jan 6, 2025
Comment on lines
846
to
849
| } else { | ||
| password = await this.getSshKeyPassword(); | ||
| await this.importSshKeyFromClipboard(password); | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mzieniukbw
previously approved these changes
Feb 11, 2025
Patrick-Pimentel-Bitwarden
previously approved these changes
Feb 11, 2025
quexten
dismissed stale reviews from Patrick-Pimentel-Bitwarden, mzieniukbw, gbubemismith, addisonbeck, and audreyality
via
1d7c466
…om/bitwarden/clients into km/pm-16227/ssh-import-web-browser
quexten
requested review from
addisonbeck,
audreyality,
gbubemismith and
coltonhurst
audreyality
approved these changes
Mar 6, 2025
gbubemismith
approved these changes
Mar 6, 2025
mzieniukbw
approved these changes
Mar 10, 2025
addisonbeck
approved these changes
Mar 10, 2025
coltonhurst
approved these changes
Mar 10, 2025
|
blackwood
pushed a commit
that referenced
this pull request
Mar 24, 2025
* Move import to sdk and enable it in browser/web * Add uncomitted files * Update package lock * Fix prettier formatting * Fix build * Rewrite import logic * Update ssh import logic for cipher form component * Fix build on browser * Break early in retry logic * Fix build * Fix build * Fix build errors * Update paste icons and throw error on wrong import * Fix tests * Fix build for cli * Undo change to jest config * Undo change to feature flag enum * Remove unneeded lifetime * Fix browser build * Refactor control flow * Fix i18n key and improve import behavior * Remove for loop limit * Clean up tests * Remove unused code * Update libs/vault/src/cipher-form/components/sshkey-section/sshkey-section.component.ts Co-authored-by: SmithThe4th <[email protected]> * Move import logic to service and add tests * Fix linting * Remove erroneous includes * Attempt to fix storybook * Fix storybook, explicitly implement ssh-import-prompt service abstraction * Fix eslint * Update libs/importer/src/importers/bitwarden/bitwarden-json-importer.ts Co-authored-by: ✨ Audrey ✨ <[email protected]> * Fix services module * Remove ssh import sdk init code * Add tests for errors * Fix import * Fix import * Fix pkcs8 encrypted key not parsing * Fix import button showing on web --------- Co-authored-by: SmithThe4th <[email protected]> Co-authored-by: ✨ Audrey ✨ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16227
📔 Objective
Makes use of the sdk in order to handle import on desktop web and browser. Drops importer code from
desktop_nativesince it's not needed there anymore.📸 Screenshots
Screen.Recording.2025-01-15.at.12.59.04.mov
Screen.Recording.2025-01-15.at.12.52.06.mov
Failed import:
Screen.Recording.2025-01-15.at.13.10.25.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes