Skip to content

Conversation

@neuronull
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27193

📔 Objective

Add documentation for the requirement to have .nsis file adjacent to the installer for Windows builds.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@neuronull neuronull requested a review from vgrassia December 15, 2025 20:44
@neuronull neuronull self-assigned this Dec 15, 2025
@neuronull neuronull requested a review from a team as a code owner December 15, 2025 20:44
@claude
Copy link

claude bot commented Dec 15, 2025

Claude finished @neuronull's task in 1m 58s —— View job


Code Review Complete

The documentation changes have been reviewed. The agent has analyzed the new Windows NSIS troubleshooting instructions and identified several areas for improvement regarding clarity and completeness of the instructions.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Logo
Checkmarx One – Scan Summary & Details68117648-90dd-4e88-9a8b-dadbfeb19226

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Member

@coltonhurst coltonhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thanks for adding this @neuronull!

One general question I'm sure you thought about. Why have this on its own page, versus a small section added under the troubleshooting section? I'm not against it having its own page, but I'm wondering if some things could be made more concise to fit it there?

Another option is keeping the new page and adding the problem to the troubleshooting section with a link to the new page as the solution.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 17, 2025

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9bd8f29
Status: ✅  Deploy successful!
Preview URL: https://68720c0f.contributing-docs.pages.dev
Branch Preview URL: https://autofill-pm-27193-desktop-wi.contributing-docs.pages.dev

View logs

@neuronull neuronull merged commit 1730792 into main Dec 17, 2025
19 checks passed
@neuronull neuronull deleted the autofill/pm-27193/desktop-windows-build-installing branch December 17, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants