-
Notifications
You must be signed in to change notification settings - Fork 21
Add Desktop Windows .nsis instructions #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Desktop Windows .nsis instructions #730
Conversation
|
Claude finished @neuronull's task in 1m 58s —— View job Code Review CompleteThe documentation changes have been reviewed. The agent has analyzed the new Windows NSIS troubleshooting instructions and identified several areas for improvement regarding clarity and completeness of the instructions. |
|
Great job! No new security vulnerabilities introduced in this pull request |
coltonhurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks for adding this @neuronull!
One general question I'm sure you thought about. Why have this on its own page, versus a small section added under the troubleshooting section? I'm not against it having its own page, but I'm wondering if some things could be made more concise to fit it there?
Another option is keeping the new page and adding the problem to the troubleshooting section with a link to the new page as the solution.
Deploying contributing-docs with
|
| Latest commit: |
9bd8f29
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://68720c0f.contributing-docs.pages.dev |
| Branch Preview URL: | https://autofill-pm-27193-desktop-wi.contributing-docs.pages.dev |

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27193
📔 Objective
Add documentation for the requirement to have
.nsisfile adjacent to the installer for Windows builds.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes