Skip to content

Fix CVE-2025-10282, again??#2750

Merged
TheTechromancer merged 3 commits intodevfrom
fix-CVE-2025-10282-again
Oct 25, 2025
Merged

Fix CVE-2025-10282, again??#2750
TheTechromancer merged 3 commits intodevfrom
fix-CVE-2025-10282-again

Conversation

@TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Oct 25, 2025

There was a problem merging the gitlab fix. This PR implements the original fix of removing gitlab.py and breaking it into two separate modules, one for gitlab.com and one for on-prem.

@justinsteven

@TheTechromancer TheTechromancer changed the base branch from stable to dev October 25, 2025 07:24
@justinsteven
Copy link

So nice they patched it twice 😌

@TheTechromancer TheTechromancer changed the title Fix CVE 2025 10282, again?? Fix CVE-2025-10282, again?? Oct 25, 2025
@TheTechromancer
Copy link
Collaborator Author

patch me once, shame on me. patch me twice, uh, can't get patched again

@github-actions
Copy link
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs fix-CVE-2025-10282-again (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 3.79ms 3.86ms +1.6%
Bloom Filter Large Scale Dns Brute Force 17.41ms 17.54ms +0.8%
Large Closest Match Lookup 318.98ms 310.89ms -2.5%
Realistic Closest Match Workload 173.60ms 171.02ms -1.5%
Event Validation Full Scan Startup Small Batch 398.33ms 415.43ms +4.3%
Event Validation Full Scan Startup Large Batch 708.64ms 709.19ms +0.1%
Make Event Autodetection Small 26.86ms 25.86ms -3.7%
Make Event Autodetection Large 272.93ms 263.77ms -3.4%
Make Event Explicit Types 11.82ms 11.48ms -2.9%
Excavate Single Thread Small 3.499s 3.451s -1.4%
Excavate Single Thread Large 9.005s 9.005s -0.0%
Excavate Parallel Tasks Small 3.675s 3.647s -0.8%
Excavate Parallel Tasks Large 6.950s 6.970s +0.3%
Is Ip Performance 2.90ms 2.90ms -0.1%
Make Ip Type Performance 10.66ms 10.68ms +0.2%
Mixed Ip Operations 4.17ms 4.15ms -0.7%
Typical Queue Shuffle 54.04µs 55.46µs +2.6%
Priority Queue Shuffle 590.48µs 599.16µs +1.5%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.13

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

❌ Patch coverage is 90.55118% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 92%. Comparing base (95dacc0) to head (76a680c).
⚠️ Report is 24 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/gitlab_onprem.py 89% 5 Missing ⚠️
bbot/modules/templates/gitlab.py 91% 5 Missing ⚠️
bbot/modules/gitlab_com.py 89% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2750   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        407     410    +3     
  Lines      33817   33826    +9     
=====================================
+ Hits       30845   30847    +2     
- Misses      2972    2979    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheTechromancer TheTechromancer merged commit 162675b into dev Oct 25, 2025
17 checks passed
@TheTechromancer TheTechromancer deleted the fix-CVE-2025-10282-again branch October 27, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants