WEST not a valid option for satellite selector

[DirkMPetersen]

When defining the desired satellite, using EAST works fine, but defining it as "WEST" does not when using the example below:

G = GOES(satellite="WEST", product="ABI-L1b-RadC", domain=selected_domain, bands=selected_option_actual)

[coliveir-aer]

@DirkMPetersen You can use satellite=18 for west. It defaults to 17 which is now an on-orbit spare. As of next week EAST won't work either, since G19 is becoming operational instead of G16.

[DirkMPetersen]

I am aware that there were other options to call the data, but good to know that EAST and WEST aren't going to work, Will work out logic based on a given date to select the proper satellite in my data grabbing script

[blaylockbk]

yeah, there is a design flaw here. You set the satellite number when creating a GOES() object, but when you call GOES(satellite="EAST").latest() it defaults to noaa-goes16, which isn't valid anymore.

goes2go/src/goes2go/NEW.py

Lines 114 to 125 in 8d06efe

	def _check_satellite(self):
	if isinstance(self.satellite, int):
	self.satellite = f"noaa-goes{self.satellite}"
	elif isinstance(self.satellite, str):
	if self.satellite.upper() == "EAST":
	self.satellite = "noaa-goes16"
	elif self.satellite.upper() == "WEST":
	self.satellite = "noaa-goes17"
	else:
	# look for the satellite number in the string (i.e.g, 'G16', 'goes16')
	self.satellite = re.sub("[^0-9]", "", self.satellite)
	self.satellite = f"noaa-goes{self.satellite}"

Perhaps the best way to redesign this is to interpret the "WEST" and "EAST" alias in each of the other methods and not in GOES.__init__.