fix: slot length is a ratio #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaffney
reviewed
Jun 13, 2025
cmd/gouroboros/query.go
Outdated
| @@ -140,7 +140,7 @@ func testQuery(f *globalFlags) { | |||
| fmt.Printf("era-history:\n") | |||
| for eraId, era := range eraHistory { | |||
| fmt.Printf( | |||
| "id = %d, begin slot/epoch = %d/%d, end slot/epoch = %d/%d, epoch length = %d, slot length (ms) = %d, slots per KES period = %d\n", | |||
| "id = %d, begin slot/epoch = %d/%d, end slot/epoch = %d/%d, epoch length = %d, slot length (ms) = %f, slots per KES period = %d\n", | |||
There was a problem hiding this comment.
I think this still needs to be %d because the value is in milliseconds
There was a problem hiding this comment.
I need to convert it, then.
ledger/shelley/genesis.go
Outdated
| @@ -35,7 +35,7 @@ type ShelleyGenesis struct { | |||
| EpochLength int `json:"epochLength"` | |||
| SlotsPerKESPeriod int `json:"slotsPerKESPeriod"` | |||
| MaxKESEvolutions int `json:"maxKESEvolutions"` | |||
| SlotLength int `json:"slotLength"` | |||
| SlotLength float32 `json:"slotLength"` | |||
There was a problem hiding this comment.
We should use common.GenesisRat for this instead. It will properly maintain the ratio instead of being lossy like float32
wolf31o2
force-pushed
the
fix/slot-length-float
branch
from
bbb799f to
e8b0526
Compare
Signed-off-by: Chris Gianelloni <[email protected]>
wolf31o2
force-pushed
the
fix/slot-length-float
branch
from
e8b0526 to
e36fc0f
Compare
agaffney
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
devnetconfig.json we ship in the container uses a slot length of 0.1