Skip to content

feat: Support getting ScriptRef from TransactionOutput interface #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

feat: Support getting ScriptRef from TransactionOutput interface #1051

merged 2 commits into from
Jul 3, 2025

Conversation

arepala-uml
Copy link
Contributor

  1. Extended common.TransactionOutput interface with GetScriptRef() method
  2. Implemented GetScriptRef() in BabbageTransactionOutput to return actual ScriptRef (CBOR.LazyValue)
  3. Added stub GetScriptRef() implementations returning nil in other eras such as Shelley, Mary, Alonzo, and Byron

Closes #1044

@arepala-uml
feat(ledger): Added GetScriptRef() support across eras to expose Scri…
58bc927 
…ptRef in TransactionOutput

Signed-off-by: Akhil Repala <[email protected]>
@arepala-uml arepala-uml marked this pull request as ready for review June 30, 2025 07:14
@arepala-uml arepala-uml requested a review from a team as a code owner June 30, 2025 07:14
@arepala-uml arepala-uml requested review from wolf31o2 and agaffney June 30, 2025 07:14
agaffney
agaffney previously requested changes Jul 1, 2025
View reviewed changes
@arepala-uml
feat(ledger): Modified the GetScriptRef() to ScriptRef() for constist…
75be3da 
…ency and to be idiomatic Go

Signed-off-by: Akhil Repala <[email protected]>
@arepala-uml arepala-uml requested a review from agaffney July 3, 2025 06:37
@wolf31o2 wolf31o2 dismissed agaffney’s stale review July 3, 2025 14:51

Comments addressed

@wolf31o2 wolf31o2 merged commit 33ce3ea into main Jul 3, 2025
9 checks passed
@wolf31o2 wolf31o2 deleted the script_reference_transaction branch July 3, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

@agaffney agaffney Awaiting requested review from agaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support getting ScriptRef from TransactionOutput interface
3 participants
@arepala-uml @wolf31o2 @agaffney