Skip to content

test(ledger): added blocks required for testing for all the eras except Conway #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

jkawan
Copy link
Contributor

@jkawan jkawan commented Jul 7, 2025

  1. Collected blocks for all the eras (except Conway) using epoch, hash and slot number. And also used https://cexplorer.io/
  2. Have added the blocks in params_test.go file (except byron) for now but can move it around to any file as required by tests later

Closes #1025

@jkawan jkawan requested a review from a team as a code owner July 7, 2025 18:15
Copy link
Contributor

@agaffney agaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The block hex strings should go in a new block_test.go for each era rather than in an existing unrelated test file.

@wolf31o2 wolf31o2 dismissed agaffney’s stale review July 8, 2025 20:30

Requested changes were made.

@wolf31o2 wolf31o2 merged commit ba18252 into main Jul 8, 2025
9 checks passed
@wolf31o2 wolf31o2 deleted the blocks_for_test branch July 8, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect blocks from each era for tests
3 participants