Skip to content

Drop toJSON & toCSS #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2024
Merged

Drop toJSON & toCSS #84

merged 2 commits into from
Dec 9, 2024

Conversation

Ayc0
Copy link
Collaborator

@Ayc0 Ayc0 commented Dec 9, 2024

toJSON & toCSS were design to work nicely with CSS-in-JS (specially styletron).

But this was a long long time ago. Since then:

  • CSS-in-JS fell in term of usages,
  • a lot of different syntaxes are supported, either by different CSS-in-JS engines, or even in CSS / CSS preprocessors regarding how media queries & nesting should be written

Supporting this doesn't really makes sense. And makes the codebase heavier. Let's just drop it

@Ayc0 Ayc0 enabled auto-merge December 9, 2024 20:09
@Ayc0 Ayc0 merged commit d1e9fb9 into main Dec 9, 2024
2 checks passed
@Ayc0 Ayc0 deleted the Ayc0/CSS-in-JS branch December 9, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ayc0