Add supprt for new c23 deallocators #817
Open
+293
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces 2 new functions to add support for `free_sized` and `free_aligned_sized` deallocators introduced in c23. We ensure that `free_sized` and `free_aligned_sized` are skipped if unavailable otherwise we get a `FREE` record recorded for them. Signed-off-by: Nana Adjei Manu <[email protected]>
godlygeek
requested changes
Aug 20, 2025
Remove `glibc` guards for new functions to support all libc implementations. Updates tests to skip if compilation fails on a specific platform. Signed-off-by: Nana Adjei Manu <[email protected]>
godlygeek
reviewed
Aug 28, 2025
Update line number assertions in three failing integration tests to match current file structure after recent code additions. The tests were failing due to line number shifts caused by: - Addition of C23 deallocator support tests - Code review improvements Tests affected: - test_misbehaving_extension: 83 → 85 - test_extension_that_uses_pygilstate_ensure: 154 → 156, 155 → 157 - test_native_dlopen: 226 → 228 Signed-off-by: Nana Adjei Manu <[email protected]>
claeusdev
force-pushed
the
support_new_deallocators
branch
from
653f4e6 to
79ca2a2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 92.16% 91.81% -0.36%
==========================================
Files 95 95
Lines 11936 11981 +45
Branches 412 414 +2
==========================================
- Hits 11001 11000 -1
- Misses 935 981 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #725
This commit introduces 2 new functions to add support for
free_sizedandfree_aligned_sizeddeallocators introduced in c23.Tests ensure that
free_sizedandfree_aligned_sizedare skipped if unavailable otherwise we get aFREErecord recorded for them.