Added access to the coroutine context from within any function call.#117
Merged
accelerated merged 2 commits intobloomberg:masterfrom Sep 12, 2019
Merged
Added access to the coroutine context from within any function call.#117accelerated merged 2 commits intobloomberg:masterfrom
accelerated merged 2 commits intobloomberg:masterfrom
Conversation
…Changed namespace cls to local Signed-off-by: Alexander Damian <adamian@bloomberg.net>
Contributor
Author
|
@demin80 can you please take a look? |
Signed-off-by: Alexander Damian <adamian@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Damian adamian@bloomberg.net
Describe your changes
yield,sleepor call anyICoroContextAPI (such as creating new coroutines) if the function is invoked from a coroutine.quantum::clstoquantum::local.GenericFutureclass. This facade util class can wrap any future type at runtime, when the execution context is unknown and can be determined viaquantum::local::context();Example:
Testing performed
Created specific GTEST for this scenario.